net/socket/ssl_client_socket_nss.cc - Issue 19269012: Don't persist HPKP if PrivacyMode is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 19269012: Don't persist HPKP if PrivacyMode is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address codereview nit and fix compilation error in OFFICIAL_BUILD. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_nss.cc

diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc

index acc1b0dee2e0af9f773f349b77691fb4e350a72e..24371a0d08859531a08779ad63772188fee0a59f 100644

--- a/net/socket/ssl_client_socket_nss.cc

+++ b/net/socket/ssl_client_socket_nss.cc

@@ -3442,7 +3442,7 @@ int SSLClientSocketNSS::DoVerifyCertComplete(int result) {

TransportSecurityState::DomainState domain_state;

if (transport_security_state_->GetDomainState(host, sni_available,

- &domain_state) &&

+ true, &domain_state) &&

domain_state.HasPublicKeyPins()) {

mef 2013/09/20 15:53:30 I'm not 100% sure that this is right thing to do h

if (!domain_state.CheckPublicKeyPins(

server_cert_verify_result_.public_key_hashes)) {

« no previous file with comments | « net/http/transport_security_state_unittest.cc ('k') | net/socket_stream/socket_stream.h » ('j') | no next file with comments »