Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1926823003: (Merge to M-51) Fix Chrome OS shelf locking for chromebook lid open/close. (Closed)

Created:
4 years, 7 months ago by msw
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

(Merge to M-51) Fix Chrome OS shelf locking for chromebook lid open/close. Do not allow shelf alignment changes while locked. Fixes a regression from https://codereview.chromium.org/1851883002 Extends my earlier fix https://codereview.chromium.org/1877543002 BUG=603243 TEST=Closing/opening chromebook lid with left-aligned shelf works as expected. R=sky@chromium.org Review URL: https://codereview.chromium.org/1920073002 Cr-Commit-Position: refs/heads/master@{#389673} (cherry picked from commit 0d806bc979f45e4dfd4c701c9f518bcff52b23c8) Committed: https://chromium.googlesource.com/chromium/src/+/f81a9c3501848333033c2a2a196bf475da5a8c38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -60 lines) Patch
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/shelf/shelf.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 2 chunks +0 lines, -57 lines 0 comments Download
M ash/shelf/shelf_locking_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/shelf/shelf_locking_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A ash/shelf/shelf_locking_manager_unittest.cc View 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
msw
4 years, 7 months ago (2016-04-27 18:34:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f81a9c3501848333033c2a2a196bf475da5a8c38.

Powered by Google App Engine
This is Rietveld 408576698