Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1920073002: Fix Chrome OS shelf locking for chromebook lid open/close. (Closed)

Created:
4 years, 8 months ago by msw
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, oshima+watch_chromium.org, kalyank, hashimoto+watch_chromium.org, davemoore+watch_chromium.org, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Chrome OS shelf locking for chromebook lid open/close. Do not allow shelf alignment changes while locked. Fixes a regression from https://codereview.chromium.org/1851883002 Extends my earlier fix https://codereview.chromium.org/1877543002 BUG=603243 TEST=Closing/opening chromebook lid with left-aligned shelf works as expected. R=sky@chromium.org Committed: https://crrev.com/0d806bc979f45e4dfd4c701c9f518bcff52b23c8 Cr-Commit-Position: refs/heads/master@{#389673}

Patch Set 1 #

Patch Set 2 : Cleanup. #

Patch Set 3 : Update and add unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -60 lines) Patch
M ash/ash.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/shelf/shelf.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 2 2 chunks +0 lines, -57 lines 0 comments Download
M ash/shelf/shelf_locking_manager.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/shelf/shelf_locking_manager.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
A ash/shelf/shelf_locking_manager_unittest.cc View 1 2 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 8 months ago (2016-04-25 22:42:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920073002/20001
4 years, 8 months ago (2016-04-25 22:42:52 UTC) #5
sky
LGTM - if you can, add test coverage.
4 years, 8 months ago (2016-04-25 23:39:10 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-25 23:46:59 UTC) #8
msw
I updated/added tests; ptal as you have time. Landing.
4 years, 8 months ago (2016-04-26 01:42:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920073002/40001
4 years, 8 months ago (2016-04-26 01:43:45 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-26 02:38:32 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 02:40:03 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0d806bc979f45e4dfd4c701c9f518bcff52b23c8
Cr-Commit-Position: refs/heads/master@{#389673}

Powered by Google App Engine
This is Rietveld 408576698