Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Issue 1926693003: [compiler] Remove deprecated CompilationJob status. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-rename-compilation-job
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove deprecated CompilationJob status. The status FAILED and BAILED_OUT only distinguishes between whether an exception is pending or not. Such a distinction is obsolete by now as all callers check for pending exceptions directly. Also it is impossible for any concurrent part of the job to actually set a pending exception, hence even the assertion that the concurrent part does not return FAILED is obsolete. R=bmeurer@chromium.org Committed: https://crrev.com/a1cd3cc8aa703e3bd21b380006b37b9f0229d63c Cr-Commit-Position: refs/heads/master@{#35834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M src/compiler.h View 3 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/optimizing-compile-dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
Benedikt: PTAL. Andreas: FYI.
4 years, 7 months ago (2016-04-27 17:27:27 UTC) #2
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-04-27 17:38:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926693003/1
4 years, 7 months ago (2016-04-27 18:36:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 18:38:42 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1cd3cc8aa703e3bd21b380006b37b9f0229d63c
Cr-Commit-Position: refs/heads/master@{#35834}

Powered by Google App Engine
This is Rietveld 408576698