src/optimizing-compile-dispatcher.cc - Issue 1926693003: [compiler] Remove deprecated CompilationJob status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/optimizing-compile-dispatcher.cc

Issue 1926693003: [compiler] Remove deprecated CompilationJob status. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-rename-compilation-job

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/optimizing-compile-dispatcher.cc

diff --git a/src/optimizing-compile-dispatcher.cc b/src/optimizing-compile-dispatcher.cc

index d2b837b25cd50a41e1c4ffd0d20721fb71e7bebe..a6ac143748fb92252cf456e6853b7dea5d67e6ba 100644

--- a/src/optimizing-compile-dispatcher.cc

+++ b/src/optimizing-compile-dispatcher.cc

@@ -107,8 +107,7 @@ void OptimizingCompileDispatcher::CompileNext(CompilationJob* job) {

// The function may have already been optimized by OSR. Simply continue.

CompilationJob::Status status = job->OptimizeGraph();

- USE(status); // Prevent an unused-variable error in release mode.

- DCHECK(status != CompilationJob::FAILED);

+ USE(status); // Prevent an unused-variable error.

// The function may have already been optimized by OSR. Simply continue.

// Use a mutex to make sure that functions marked for install

« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | no next file » | no next file with comments »