Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1925743002: [compiler] Rename OptimizingCompileJob to CompilationJob. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-simplify-29
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Rename OptimizingCompileJob to CompilationJob. R=bmeurer@chromium.org Committed: https://crrev.com/5a54000eda66f8659a1a892d7b3a20035b24f8fa Cr-Commit-Position: refs/heads/master@{#35832}

Patch Set 1 #

Patch Set 2 : Fix tests as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -74 lines) Patch
M src/compiler.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler.cc View 13 chunks +17 lines, -20 lines 0 comments Download
M src/compiler/pipeline.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/optimizing-compile-dispatcher.h View 5 chunks +7 lines, -8 lines 0 comments Download
M src/optimizing-compile-dispatcher.cc View 6 chunks +13 lines, -19 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 1 chunk +4 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1923293002 Patch 1

Dependent Patchsets:

Issue 1926693003 Patch 1

Messages

Total messages: 8 (3 generated)
Michael Starzinger
Pure renaming. Now that the compilation job is used for WASM as well, the general ...
4 years, 7 months ago (2016-04-27 16:55:18 UTC) #2
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-04-27 17:38:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925743002/20001
4 years, 7 months ago (2016-04-27 17:51:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 17:54:25 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:26 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5a54000eda66f8659a1a892d7b3a20035b24f8fa
Cr-Commit-Position: refs/heads/master@{#35832}

Powered by Google App Engine
This is Rietveld 408576698