Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1926663002:
Reland of git cl try: don't skip presubmit builders, but set dry_run property. (Closed)
|
Created:
4 years, 7 months ago by tandrii(chromium) Modified:
4 years, 7 months ago CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionReland of git cl try: don't skip presubmit builders, but set dry_run property.
With a fix: actually set dry_run for presubmit, and don't set it for other builders.
R=machenbach@chromium.org,sergiyb@chromium.org
BUG=601128, 594127, 591030
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300295
Patch Set 1 #Patch Set 2 : Reland with trivail fix #
Total comments: 1
Messages
Total messages: 37 (16 generated)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926663002/1
Description was changed from ========== git cl try: don't skip presubmit builderes, but set dry_run property. R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 ========== to ========== git cl try: don't skip presubmit builders, but set dry_run property. R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 ==========
lgtm if the presubmit change that uses the property lands first
The CQ bit was unchecked by rmistry@google.com
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926663002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
dependent change laded, let's see if presubmit still works.
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926663002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926663002/1
Message was sent while issue was closed.
Description was changed from ========== git cl try: don't skip presubmit builders, but set dry_run property. R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 ========== to ========== git cl try: don't skip presubmit builders, but set dry_run property. R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300265 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300265
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1929483004/ by tandrii@chromium.org. The reason for reverting is: Schedules fine, but property not set: https://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14295/ reverting first, then investigating..
Message was sent while issue was closed.
Description was changed from ========== git cl try: don't skip presubmit builders, but set dry_run property. R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300265 ========== to ========== git cl try: don't skip presubmit builders, but set dry_run property. R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 ==========
Description was changed from ========== git cl try: don't skip presubmit builders, but set dry_run property. R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 ========== to ========== Reland of git cl try: don't skip presubmit builders, but set dry_run property. With a fix: actually set dry_run for presubmit, and don't set it for other builders. R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 ==========
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926663002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Tested locally - result: https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/bui... it's read, but dry_run property is set. https://codereview.chromium.org/1926663002/diff/20001/git_cl.py File git_cl.py (right): https://codereview.chromium.org/1926663002/diff/20001/git_cl.py#newcode340 git_cl.py:340: if 'presubmit' in builder.lower(): derp
The CQ bit was checked by tandrii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergiyb@chromium.org, machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/1926663002/#ps20001 (title: "Reland with trivail fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926663002/20001
Message was sent while issue was closed.
Description was changed from ========== Reland of git cl try: don't skip presubmit builders, but set dry_run property. With a fix: actually set dry_run for presubmit, and don't set it for other builders. R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 ========== to ========== Reland of git cl try: don't skip presubmit builders, but set dry_run property. With a fix: actually set dry_run for presubmit, and don't set it for other builders. R=machenbach@chromium.org,sergiyb@chromium.org BUG=601128,594127,591030 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300295 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300295
Message was sent while issue was closed.
lgtm - that means when committing last time the dry_run property was set for all other builder types? But had probably no effect in anyway, I guess...
Message was sent while issue was closed.
On 2016/04/29 08:16:05, Michael Achenbach wrote: > lgtm - that means when committing last time the dry_run property was set for all > other builder types? Yeah! > But had probably no effect in anyway, I guess... Well, I think so, but CQ would have rejected them all.
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1928373002/ by machenbach@chromium.org. The reason for reverting is: Now only presubmit is scheduled on dry run, example CL: https://codereview.chromium.org/1804003002.
Message was sent while issue was closed.
On 2016/04/29 12:21:28, Michael Achenbach wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/1928373002/ by mailto:machenbach@chromium.org. > > The reason for reverting is: Now only presubmit is scheduled on dry run, example > CL: > https://codereview.chromium.org/1804003002. aaaaaaannnnnnnddd it was re-landed in https://codereview.chromium.org/1930363003/ |
