git_cl.py - Issue 1926663002: Reland of git cl try: don't skip presubmit builders, but set dry_run property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 1926663002: Reland of git cl try: don't skip presubmit builders, but set dry_run property. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Reland with trivail fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 0acb9cd59ba2f67a73dc357a21e5ef0d2f851b14..fd2dcea4189f99632da41dafc2874c857f599091 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -337,6 +337,8 @@ def trigger_try_jobs(auth_config, changelist, options, masters, category):

'rietveld': rietveld_url,

}

+ if 'presubmit' in builder.lower():

tandrii(chromium) 2016/04/28 19:39:52 derp

+ parameters['properties']['dry_run'] = 'true'

if tests:

parameters['properties']['testfilter'] = tests

if properties:

@@ -4316,8 +4318,7 @@ def CMDtry(parser, args):

for master, builders in cq_masters.iteritems():

for builder in builders:

# Skip presubmit builders, because these will fail without LGTM.

- if 'presubmit' not in builder.lower():

- masters.setdefault(master, {})[builder] = ['defaulttests']

+ masters.setdefault(master, {})[builder] = ['defaulttests']

if masters:

return masters

« no previous file with comments | « no previous file | no next file » | no next file with comments »