Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1804003002:
[Ignition] Test ignition on all bots. (Closed)
|
Created:
4 years, 9 months ago by Michael Achenbach Modified:
4 years, 7 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Ignition] Test ignition on all bots.
This adds ignition to the testing variants that are run on all
bots.
Failing tests can only be skipped with the NO_IGNITION
keyword in status files. Existing expectations for the
ignition_turbofan variant are all duplicated and use the
NO_IGNITION keyword as well now.
BUG=v8:4280
LOG=N
Committed: https://crrev.com/132c09ed619f23fb7c6d26a4e3552c703389eabd
Cr-Commit-Position: refs/heads/master@{#35865}
Committed: https://crrev.com/8ba46715b0847c956d200bba43f7088cbc91793f
Cr-Commit-Position: refs/heads/master@{#35926}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : Expectations #
Total comments: 2
Patch Set 4 : Rebase 9212be866d87 #
Total comments: 1
Patch Set 5 : Fix #Patch Set 6 : Rebase #Patch Set 7 : Moar expectations #Patch Set 8 : Moar #Patch Set 9 : Stupid #Patch Set 10 : Rebase #
Messages
Total messages: 80 (39 generated)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Ignition] Test ignition on all bots. BUG= ========== to ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N ==========
machenbach@chromium.org changed reviewers: + mstarzinger@chromium.org, mythria@chromium.org, rmcilroy@chromium.org, yangguo@chromium.org
PTAL. The duplication in the status file is a bit sad, but there's no other way without a major rework of the test driver. The ignition_turbofan variant will continue to be tested on most bots, while the new ignition variant is similar to turbofan a standard variant on bots. It is not run locally for developers unless explicitly requested.
LGTM, thanks. https://codereview.chromium.org/1804003002/diff/40001/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/1804003002/diff/40001/test/cctest/cctest.stat... test/cctest/cctest.status:203: 'test-run-inlining/SimpleInliningContextDeopt': [PASS, NO_IGNITION], Some of these I think should run on the Ignition variant (without --turbo), but you can land this then I'll upload a CL to remove the tests which pass.
LGTM.
On 2016/04/27 18:51:39, Michael Starzinger wrote: > LGTM. lgtm.
OK - landing now - clean up later.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/40001
The CQ bit was unchecked by machenbach@chromium.org
Waiting to rebase c2186834942d and follow up.
https://codereview.chromium.org/1804003002/diff/40001/test/mjsunit/mjsunit.st... File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1804003002/diff/40001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:290: 'debug-stepin-builtin-callback-opt': [PASS, NO_IGNITION], Note that this entry has already been removed.
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org, mstarzinger@chromium.org, yangguo@chromium.org Link to the patchset: https://codereview.chromium.org/1804003002/#ps60001 (title: "Rebase 9212be866d87")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/60001
Pushing it through with notry as the latest patch has only expectation changes.
Description was changed from ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N ========== to ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N NOTRY=true ==========
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/60001
Message was sent while issue was closed.
Description was changed from ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N NOTRY=true ========== to ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Hmm - something is maybe not right with this patch. It adds to few tests (i.e. around 1000 only according to stdio).
Message was sent while issue was closed.
On 2016/04/28 13:35:57, Michael Achenbach wrote: > Hmm - something is maybe not right with this patch. It adds to few tests (i.e. > around 1000 only according to stdio). Jep - here's definitely a bug... looking
Message was sent while issue was closed.
https://codereview.chromium.org/1804003002/diff/60001/tools/testrunner/local/... File tools/testrunner/local/testsuite.py (right): https://codereview.chromium.org/1804003002/diff/60001/tools/testrunner/local/... tools/testrunner/local/testsuite.py:83: result -= IGNITION_VARIANT meh, this mutates self.all_variants
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1930943002/ by machenbach@chromium.org. The reason for reverting is: Will resubmit with proper fix and more test skips..
Message was sent while issue was closed.
Description was changed from ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N NOTRY=true ========== to ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N NOTRY=true ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14380)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14390)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N NOTRY=true ========== to ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/956) v8_mac_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/958) v8_mac_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...) v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/959) v8_mac_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/160001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/04/29 14:09:10, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. I dont like that the coverage bot has internal failures through this. I need to investigate this first... It also has some asan failures, the other asan bot doesnt find...
Message was sent while issue was closed.
Description was changed from ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N ========== to ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N NOTRY=true Committed: https://crrev.com/132c09ed619f23fb7c6d26a4e3552c703389eabd Cr-Commit-Position: refs/heads/master@{#35865} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/132c09ed619f23fb7c6d26a4e3552c703389eabd Cr-Commit-Position: refs/heads/master@{#35865}
Message was sent while issue was closed.
Description was changed from ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N NOTRY=true Committed: https://crrev.com/132c09ed619f23fb7c6d26a4e3552c703389eabd Cr-Commit-Position: refs/heads/master@{#35865} ========== to ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N NOTRY=true Committed: https://crrev.com/132c09ed619f23fb7c6d26a4e3552c703389eabd Cr-Commit-Position: refs/heads/master@{#35865} ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/180001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N NOTRY=true Committed: https://crrev.com/132c09ed619f23fb7c6d26a4e3552c703389eabd Cr-Commit-Position: refs/heads/master@{#35865} ========== to ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N Committed: https://crrev.com/132c09ed619f23fb7c6d26a4e3552c703389eabd Cr-Commit-Position: refs/heads/master@{#35865} ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/180001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org, mstarzinger@chromium.org, yangguo@chromium.org Link to the patchset: https://codereview.chromium.org/1804003002/#ps180001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804003002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804003002/180001
Message was sent while issue was closed.
Description was changed from ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N Committed: https://crrev.com/132c09ed619f23fb7c6d26a4e3552c703389eabd Cr-Commit-Position: refs/heads/master@{#35865} ========== to ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N Committed: https://crrev.com/132c09ed619f23fb7c6d26a4e3552c703389eabd Cr-Commit-Position: refs/heads/master@{#35865} ==========
Message was sent while issue was closed.
Committed patchset #10 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N Committed: https://crrev.com/132c09ed619f23fb7c6d26a4e3552c703389eabd Cr-Commit-Position: refs/heads/master@{#35865} ========== to ========== [Ignition] Test ignition on all bots. This adds ignition to the testing variants that are run on all bots. Failing tests can only be skipped with the NO_IGNITION keyword in status files. Existing expectations for the ignition_turbofan variant are all duplicated and use the NO_IGNITION keyword as well now. BUG=v8:4280 LOG=N Committed: https://crrev.com/132c09ed619f23fb7c6d26a4e3552c703389eabd Cr-Commit-Position: refs/heads/master@{#35865} Committed: https://crrev.com/8ba46715b0847c956d200bba43f7088cbc91793f Cr-Commit-Position: refs/heads/master@{#35926} ==========
Message was sent while issue was closed.
Patchset 10 (id:??) landed as https://crrev.com/8ba46715b0847c956d200bba43f7088cbc91793f Cr-Commit-Position: refs/heads/master@{#35926} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
