Smooth scroll animation should not override scroll anchoring update (MT)

Smooth scroll animation should not override scroll anchoring update (MT)

Previously, the adjustment made by scroll anchoriing would be overwritten by
the scroll position updates from the scroll offset animation because it worked
with absolute scroll offset values.

Now, when an adjustment is about to be made with an ongoing animation initiated
by MT, we cancel that animation, update the curve, and schedule an animatiion
with the update target. We do this by introducing a new state to the
ScrollAnimator class which also fixes issue 599876.

BUG=594456, 599876
Committed: https://crrev.com/98eaa26e00d063ccf9f31cd85261f66441bcd5b8
Cr-Commit-Position: refs/heads/master@{#390997}

[ymalik, 2016-04-27 03:57:24]

Description was changed from

==========
Smooth scroll animation should not override scroll anchoring update (MT)

Previously, the adjustment made by scroll anchoriing would be overwritten by
the scroll position updates from the scroll offset animation because it worked
with absolute scroll offset values.

Now, when an adjustment is about to be made with an ongoing animation initiated
by MT, we cancel that animation, update the curve, and schedule an animatiion
with the update target. We do this by introducing a new state to the
ScrollAnimator class which also fixes issue 599876.

BUG=594456,599876
==========

to

==========
Smooth scroll animation should not override scroll anchoring update (MT)

Previously, the adjustment made by scroll anchoriing would be overwritten by
the scroll position updates from the scroll offset animation because it worked
with absolute scroll offset values.

Now, when an adjustment is about to be made with an ongoing animation initiated
by MT, we cancel that animation, update the curve, and schedule an animatiion
with the update target. We do this by introducing a new state to the
ScrollAnimator class which also fixes issue 599876.

BUG=594456,599876
==========

[ymalik, 2016-04-27 03:57:24]

ymalik@chromium.org changed reviewers:
+ ajuma@chromium.org

[ymalik, 2016-04-27 03:58:57]

Note that this CL is dependent on https://codereview.chromium.org/1895293002/ so
that scroll anchoring can be enable for the test.

[ajuma, 2016-04-27 15:46:11]

lgtm

https://codereview.chromium.org/1926473003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/ongoing-smooth-scroll-anchors.html
(right):

https://codereview.chromium.org/1926473003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/ongoing-smooth-scroll-anchors.html:38:
var endY = 305;
Should this be 315 (by the math from the comment above)?

[ymalik, 2016-04-27 16:21:39]

https://codereview.chromium.org/1926473003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/ongoing-smooth-scroll-anchors.html
(right):

https://codereview.chromium.org/1926473003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/ongoing-smooth-scroll-anchors.html:38:
var endY = 305;
On 2016/04/27 15:46:10, ajuma wrote:
> Should this be 315 (by the math from the comment above)?

The comment is wrong. Fixed.

[ymalik, 2016-04-28 15:24:42]

ymalik@chromium.org changed reviewers:
+ jbroman@chromium.org

[ymalik, 2016-04-28 15:24:43]

+jbroman for Source/platform

[jbroman, 2016-04-28 16:48:45]

rs lgtm

[ymalik, 2016-04-29 18:56:32]

The CQ bit was checked by ymalik@chromium.org

[ymalik, 2016-04-29 18:56:33]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org,
jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1926473003/#ps40001
(title: "rebase master")

[commit-bot: I haz the power, 2016-04-29 18:56:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926473003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926473003/40001

[commit-bot: I haz the power, 2016-04-29 20:52:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 20:52:41]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ymalik, 2016-05-02 16:52:48]

The CQ bit was checked by ymalik@chromium.org

[ymalik, 2016-05-02 16:52:49]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org,
jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1926473003/#ps60001
(title: "disable test for mac")

[commit-bot: I haz the power, 2016-05-02 16:53:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926473003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926473003/60001

[commit-bot: I haz the power, 2016-05-02 18:21:31]

Description was changed from

==========
Smooth scroll animation should not override scroll anchoring update (MT)

Previously, the adjustment made by scroll anchoriing would be overwritten by
the scroll position updates from the scroll offset animation because it worked
with absolute scroll offset values.

Now, when an adjustment is about to be made with an ongoing animation initiated
by MT, we cancel that animation, update the curve, and schedule an animatiion
with the update target. We do this by introducing a new state to the
ScrollAnimator class which also fixes issue 599876.

BUG=594456,599876
==========

to

==========
Smooth scroll animation should not override scroll anchoring update (MT)

Previously, the adjustment made by scroll anchoriing would be overwritten by
the scroll position updates from the scroll offset animation because it worked
with absolute scroll offset values.

Now, when an adjustment is about to be made with an ongoing animation initiated
by MT, we cancel that animation, update the curve, and schedule an animatiion
with the update target. We do this by introducing a new state to the
ScrollAnimator class which also fixes issue 599876.

BUG=594456,599876
==========

[commit-bot: I haz the power, 2016-05-02 18:21:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-02 18:22:38]

Description was changed from

==========
Smooth scroll animation should not override scroll anchoring update (MT)

Previously, the adjustment made by scroll anchoriing would be overwritten by
the scroll position updates from the scroll offset animation because it worked
with absolute scroll offset values.

Now, when an adjustment is about to be made with an ongoing animation initiated
by MT, we cancel that animation, update the curve, and schedule an animatiion
with the update target. We do this by introducing a new state to the
ScrollAnimator class which also fixes issue 599876.

BUG=594456,599876
==========

to

==========
Smooth scroll animation should not override scroll anchoring update (MT)

Previously, the adjustment made by scroll anchoriing would be overwritten by
the scroll position updates from the scroll offset animation because it worked
with absolute scroll offset values.

Now, when an adjustment is about to be made with an ongoing animation initiated
by MT, we cancel that animation, update the curve, and schedule an animatiion
with the update target. We do this by introducing a new state to the
ScrollAnimator class which also fixes issue 599876.

BUG=594456,599876

Committed: https://crrev.com/98eaa26e00d063ccf9f31cd85261f66441bcd5b8
Cr-Commit-Position: refs/heads/master@{#390997}
==========

[commit-bot: I haz the power, 2016-05-02 18:22:39]

Patchset 4 (id:??) landed as
https://crrev.com/98eaa26e00d063ccf9f31cd85261f66441bcd5b8
Cr-Commit-Position: refs/heads/master@{#390997}