third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h - Issue 1926473003: Smooth scroll animation should not override scroll anchoring update (MT)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

Issue 1926473003: Smooth scroll animation should not override scroll anchoring update (MT) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: disable test for mac Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

index 6819510c50b43c8c4dbd2589c698f84585f8be53..9b69df747f69c2eef0b5c786e4b457f06511894c 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

@@ -114,6 +114,12 @@ protected:

// on the main thread. This could happen if a main thread scrolling

// reason is added while animating the scroll offset.

RunningOnCompositorButNeedsTakeover,

+ // Waiting to cancel the animation currently running on the compositor

+ // while another animation is requested. In this case, the currently

+ // running animation is aborted and an animation to the new target

+ // from the current position is started.

+ WaitingToCancelOnCompositorButNewScroll,

};

OwnPtr<CompositorAnimationPlayer> m_compositorPlayer;