Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1926033002: depot_tools: add infra_paths recipe module for infra-specific paths (attempt #2) (Closed)

Created:
4 years, 7 months ago by Paweł Hajdan Jr.
Modified:
4 years, 7 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: add infra_paths recipe module for infra-specific paths (attempt #2) This is different from previous attempt https://codereview.chromium.org/1915463002 . The change is completely backwards-compatible, and doesn't introduce recipe expectation changes. Modules can be switched to depend on infra_paths independently, without any expectation changes either. By moving path module's config.py to paths_config.py here, we also guarantee that the returned results are going to be exactly the same. Depends on https://codereview.chromium.org/1923363003 . BUG=chromium:605919 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300324

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -17 lines) Patch
A + recipe_modules/infra_paths/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
A recipe_modules/infra_paths/api.py View 1 chunk +12 lines, -0 lines 0 comments Download
A recipe_modules/infra_paths/example.py View 1 1 chunk +28 lines, -0 lines 0 comments Download
A recipe_modules/infra_paths/example.expected/basic.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
A recipe_modules/infra_paths/example.expected/paths_buildbot_linux.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
A recipe_modules/infra_paths/example.expected/paths_buildbot_mac.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
A recipe_modules/infra_paths/example.expected/paths_buildbot_win.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
A recipe_modules/infra_paths/example.expected/paths_kitchen_linux.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
A recipe_modules/infra_paths/example.expected/paths_kitchen_mac.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
A recipe_modules/infra_paths/example.expected/paths_kitchen_win.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
A recipe_modules/infra_paths/path_config.py View 1 chunk +46 lines, -0 lines 0 comments Download
D recipe_modules/infra_paths/test_api.py View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Paweł Hajdan Jr.
4 years, 7 months ago (2016-04-28 13:16:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926033002/1
4 years, 7 months ago (2016-04-28 23:08:35 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/380)
4 years, 7 months ago (2016-04-28 23:15:08 UTC) #6
martiniss
lgtm https://codereview.chromium.org/1926033002/diff/1/recipe_modules/infra_paths/example.py File recipe_modules/infra_paths/example.py (right): https://codereview.chromium.org/1926033002/diff/1/recipe_modules/infra_paths/example.py#newcode13 recipe_modules/infra_paths/example.py:13: return maybe add an actual example here? Like ...
4 years, 7 months ago (2016-04-28 23:15:23 UTC) #7
Paweł Hajdan Jr.
https://codereview.chromium.org/1926033002/diff/1/recipe_modules/infra_paths/example.py File recipe_modules/infra_paths/example.py (right): https://codereview.chromium.org/1926033002/diff/1/recipe_modules/infra_paths/example.py#newcode13 recipe_modules/infra_paths/example.py:13: return On 2016/04/28 at 23:15:23, martiniss wrote: > maybe ...
4 years, 7 months ago (2016-04-29 09:34:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926033002/20001
4 years, 7 months ago (2016-04-29 09:35:09 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 09:37:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300324

Powered by Google App Engine
This is Rietveld 408576698