depot_tools: add infra_paths recipe module for infra-specific paths

depot_tools: add infra_paths recipe module for infra-specific paths

Depends on https://codereview.chromium.org/1906323003

BUG=chromium:605919
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184

[Paweł Hajdan Jr., 2016-04-22 14:04:39]

Description was changed from

==========
depot_tools: add infra_paths recipe module for infra-specific paths

BUG=chromium:605919
==========

to

==========
depot_tools: add infra_paths recipe module for infra-specific paths

Depends on https://codereview.chromium.org/1906323003

BUG=chromium:605919
==========

[Paweł Hajdan Jr., 2016-04-22 14:04:48]

phajdan.jr@chromium.org changed reviewers:
+ iannucci@chromium.org, martiniss@chromium.org

[iannucci, 2016-04-22 16:40:12]

https://chromiumcodereview.appspot.com/1915463002/diff/1/recipe_modules/bot_u...
File recipe_modules/bot_update/example.expected/basic.json (left):

https://chromiumcodereview.appspot.com/1915463002/diff/1/recipe_modules/bot_u...
recipe_modules/bot_update/example.expected/basic.json:26: "cwd":
"[SLAVE_BUILD]",
???

https://chromiumcodereview.appspot.com/1915463002/diff/1/recipe_modules/infra...
File recipe_modules/infra_paths/api.py (right):

https://chromiumcodereview.appspot.com/1915463002/diff/1/recipe_modules/infra...
recipe_modules/infra_paths/api.py:33: return self.c.paths[name]
why not just have a path_config.py file and configure the actual path module, to
avoid duplicating this? Then every recipe could start with
api.infra_paths.configure() or something. Eventually we should support a _loaded
hook (which we could use to make 'configs' just-another-module) which would
avoid the need for that change.

[Paweł Hajdan Jr., 2016-04-25 15:45:47]

https://codereview.chromium.org/1915463002/diff/1/recipe_modules/infra_paths/...
File recipe_modules/infra_paths/api.py (right):

https://codereview.chromium.org/1915463002/diff/1/recipe_modules/infra_paths/...
recipe_modules/infra_paths/api.py:33: return self.c.paths[name]
On 2016/04/22 at 16:40:12, iannucci wrote:
> why not just have a path_config.py file and configure the actual path module,
to avoid duplicating this? Then every recipe could start with
api.infra_paths.configure() or something. Eventually we should support a _loaded
hook (which we could use to make 'configs' just-another-module) which would
avoid the need for that change.

Replied on
https://groups.google.com/a/chromium.org/d/msg/infra-dev/yKnFNunTsdU/Jg-kSuR1...

I think e.g. adding hooks is beyond scope of a CL (not saying it won't be done,
but warranting a wider discussion).

[Paweł Hajdan Jr., 2016-04-25 20:43:18]

https://codereview.chromium.org/1915463002/diff/1/recipe_modules/bot_update/e...
File recipe_modules/bot_update/example.expected/basic.json (left):

https://codereview.chromium.org/1915463002/diff/1/recipe_modules/bot_update/e...
recipe_modules/bot_update/example.expected/basic.json:26: "cwd":
"[SLAVE_BUILD]",
On 2016/04/22 at 16:40:12, iannucci wrote:
> ???

Whoa, not sure what's the concern here.

I'll reply why I'm convinced this is safe.

This was added for swarming in the first place, where we needed to explicitly
set that path since it was different from default cwd. However, for both
buildbot and kitchen, this is the same as cwd, and therefore safe (no behavior
change actually).

Does that make sense?

[iannucci, 2016-04-25 20:43:53]

lgtm

[Paweł Hajdan Jr., 2016-04-26 08:54:35]

The CQ bit was checked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-04-26 08:54:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1915463002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-26 08:54:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915463002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915463002/20001

[commit-bot: I haz the power, 2016-04-26 08:57:48]

Description was changed from

==========
depot_tools: add infra_paths recipe module for infra-specific paths

Depends on https://codereview.chromium.org/1906323003

BUG=chromium:605919
==========

to

==========
depot_tools: add infra_paths recipe module for infra-specific paths

Depends on https://codereview.chromium.org/1906323003

BUG=chromium:605919

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
==========

[commit-bot: I haz the power, 2016-04-26 08:57:49]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300184

[tandrii(chromium), 2016-04-26 18:51:26]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1917263002/ by tandrii@chromium.org.

The reason for reverting is: breaks skia bots :(.