Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1923363003: recipe engine: add a hook for initializing recipe module with injected deps (Closed)

Created:
4 years, 7 months ago by Paweł Hajdan Jr.
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://github.com/luci/recipes-py.git@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

recipe engine: add a hook for initializing recipe module with injected deps BUG=chromium:605919 Committed: https://github.com/luci/recipes-py/commit/53217bee9af1ac4284df50b3e4e334b770eb0ddb

Patch Set 1 #

Patch Set 2 : presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M recipe_engine/loader.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M recipe_engine/recipe_api.py View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923363003/1
4 years, 7 months ago (2016-04-28 13:05:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923363003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923363003/20001
4 years, 7 months ago (2016-04-28 13:08:39 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 13:10:30 UTC) #6
Paweł Hajdan Jr.
4 years, 7 months ago (2016-04-28 13:15:45 UTC) #8
Michael Achenbach
lgtm
4 years, 7 months ago (2016-04-29 08:54:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923363003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923363003/20001
4 years, 7 months ago (2016-04-29 08:55:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/builds/200)
4 years, 7 months ago (2016-04-29 08:59:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923363003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923363003/20001
4 years, 7 months ago (2016-04-29 09:06:04 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 09:08:21 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/53217bee9af1ac4284df50b3e4e334b770e...

Powered by Google App Engine
This is Rietveld 408576698