Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1923293002: [compiler] Unify common code in GetOptimizedCode. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Unify common code in GetOptimizedCode. This moves the common code for allocating a compilation job into one single place in the compilation pipeline. This will make it easier to reason about involved lifetimes. R=bmeurer@chromium.org Committed: https://crrev.com/82ffd16087735bd754dab10f8f56ebe6c70bffaf Cr-Commit-Position: refs/heads/master@{#35831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -28 lines) Patch
M src/compiler.cc View 5 chunks +24 lines, -28 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 7 months ago (2016-04-27 13:28:58 UTC) #1
Benedikt Meurer
Very nice. LGTM.
4 years, 7 months ago (2016-04-27 17:39:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923293002/1
4 years, 7 months ago (2016-04-27 17:42:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 17:45:30 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82ffd16087735bd754dab10f8f56ebe6c70bffaf
Cr-Commit-Position: refs/heads/master@{#35831}

Powered by Google App Engine
This is Rietveld 408576698