recipe engine: require all path bases to be classes

recipe_engine/config_types.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import abc
 import os
 import re
 
 from collections import namedtuple
 
@@ skipping 62 matching lines @@
     """Returns a string representation of the path base.
 
     Args:
       api (RecipeApi) - instance of path module's RecipeApi
       test_enabled (bool) - true iff this is only for recipe expectations
     """
     raise NotImplementedError()
 
 
 class NamedBasePath(BasePath, namedtuple('NamedBasePath', 'name')):
-  # Restrict basenames to '[ALL_CAPS]'. This will help catch
-  # errors if someone attempts to provide an actual string path '/some/example'
-  # as the 'base'.
-  BASE_RE = re.compile(r'\[([A-Z][A-Z_]*)\]')
-
-  @staticmethod
-  def parse(base):
-    base_match = NamedBasePath.BASE_RE.match(base)
-    assert base_match, 'Base should be [ALL_CAPS], got %r' % base
-    return NamedBasePath(base_match.group(1).lower())
-
   def resolve(self, api, test_enabled):
     if self.name in api.c.dynamic_paths:
       return api.c.dynamic_paths[self.name]
     if self.name in api.c.base_paths:
       if test_enabled:
         return repr(self)
       return api.join(*api.c.base_paths[self.name])  # pragma: no cover
     raise KeyError(
         'Failed to resolve NamedBasePath: %s' % self.name)  # pragma: no cover
 
@@ skipping 43 matching lines @@
       base (str) - The 'name' of a base path, to be filled in at recipe runtime
         by the 'path' recipe module.
       pieces (tuple(str)) - The components of the path relative to base. These
         pieces must be non-relative (i.e. no '..' or '.', etc. as a piece).
 
     Kwargs:
       platform_ext (dict(str, str)) - A mapping from platform name (as defined
         by the 'platform' module), to a suffix for the path.
     """
     super(Path, self).__init__()
+    assert isinstance(base, BasePath), base
     assert all(isinstance(x, basestring) for x in pieces), pieces
     assert not any(x in ('..', '.', '/', '\\') for x in pieces)
+
+    self.base = base
     self.pieces = pieces
-
-    if isinstance(base, BasePath):
-      self.base = base
-    elif isinstance(base, basestring):
-      self.base = NamedBasePath.parse(base)
-    else:
-      raise ValueError('%s is not a valid base path' % (base,))
-
     self.platform_ext = kwargs.get('platform_ext', {})
 
   def __eq__(self, other):
     return (self.base == other.base and
             self.pieces == other.pieces and
             self.platform_ext == other.platform_ext)
 
   def __ne__(self, other):
     return not self.base == other
 
@@ skipping 11 matching lines @@
     if len(self.pieces) >= len(child.pieces):
       return False
     return child.pieces[:len(self.pieces)] == self.pieces
 
   def __repr__(self):
     s = "Path(%r" % self.base
     if self.pieces:
       s += ", %s" % ",".join(repr(x) for x in self.pieces)
 
     return s + ")"