Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: recipe_modules/path/example.py

Issue 1925653002: recipe engine: require all path bases to be classes (Closed) Base URL: https://github.com/luci/recipes-py.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_modules/path/api.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/path/example.py
diff --git a/recipe_modules/path/example.py b/recipe_modules/path/example.py
index 3fa8a86f59a55092b76e086e8809231305f9a5ba..cce8f417fbcc8322906c5bc021c6688a41dc4975 100644
--- a/recipe_modules/path/example.py
+++ b/recipe_modules/path/example.py
@@ -22,13 +22,12 @@ def RunSteps(api):
api.step('print package dir',
['echo', api.path.package_repo_resource('dir', 'file.py')])
- # Global dynamic paths (see config.py example for declaration):
- dynamic_path = Path('[CHECKOUT]', 'jerky')
-
assert 'checkout' not in api.path
api.path['checkout'] = api.path['tmp_base'].join('checkout')
assert 'checkout' in api.path
+ # Global dynamic paths (see config.py example for declaration):
+ dynamic_path = api.path['checkout'].join('jerky')
api.step('checkout path', ['/bin/echo', dynamic_path])
# Methods from python os.path are available via api.path.
« no previous file with comments | « recipe_modules/path/api.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698