Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1925463002: Mojo: Make device/ to not rely on connecton error notification on message loop destruction. (Closed)

Created:
4 years, 8 months ago by yzshen1
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo: Make device/ to not rely on connecton error notification on message loop destruction. - Make device/usb to use StrongBinding wherever possible. - Remove unnecessary DCHECK from DataSourceSender. This is a preparation for removing connection error notification on message loop destruction. BUG=604762 Committed: https://crrev.com/0950cefe4e9c89fd11c4077123b9084c8173fdd9 Cr-Commit-Position: refs/heads/master@{#389926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M device/serial/data_source_sender.cc View 1 chunk +0 lines, -1 line 0 comments Download
M device/usb/mojo/device_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/usb/mojo/device_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/usb/mojo/device_manager_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/usb/mojo/device_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
yzshen1
Hi, Ken. Please take a look. Thanks!
4 years, 8 months ago (2016-04-26 21:35:23 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 8 months ago (2016-04-26 21:36:19 UTC) #3
yzshen1
On 2016/04/26 21:36:19, Ken Rockot wrote: > lgtm That is fast!
4 years, 8 months ago (2016-04-26 21:36:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925463002/1
4 years, 8 months ago (2016-04-26 21:37:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 22:39:44 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 22:41:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0950cefe4e9c89fd11c4077123b9084c8173fdd9
Cr-Commit-Position: refs/heads/master@{#389926}

Powered by Google App Engine
This is Rietveld 408576698