Mojo: Make device/ to not rely on connecton error notification on message loop destruction.

device/usb/mojo/device_manager_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/usb/mojo/device_manager_impl.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
@@ skipping 29 matching lines @@
 DeviceManagerImpl::DeviceManagerImpl(
     base::WeakPtr<PermissionProvider> permission_provider,
     UsbService* usb_service,
     mojo::InterfaceRequest<DeviceManager> request)
     : permission_provider_(permission_provider),
       usb_service_(usb_service),
       observer_(this),
       binding_(this, std::move(request)),
       weak_factory_(this) {
   // This object owns itself and will be destroyed if the message pipe it is
-  // bound to is closed or the UsbService is shut down.
-  binding_.set_connection_error_handler([this]() { delete this; });
+  // bound to is closed, the message loop is destructed, or the UsbService is
+  // shut down.
   observer_.Add(usb_service_);
 }
 
 DeviceManagerImpl::~DeviceManagerImpl() {
   connection_error_handler_.Run();
 }
 
 void DeviceManagerImpl::GetDevices(EnumerationOptionsPtr options,
                                    const GetDevicesCallback& callback) {
   usb_service_->GetDevices(base::Bind(&DeviceManagerImpl::OnGetDevices,
@@ skipping 75 matching lines @@
     devices_added_.clear();
     notification->devices_removed.Swap(&devices_removed_);
 
     device_change_callbacks_.front().Run(std::move(notification));
     device_change_callbacks_.pop();
   }
 }
 
 }  // namespace usb
 }  // namespace device