Issue 1895083004: [Draft] See what tests are broken.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1895083004: [Draft] See what tests are broken.

Created:
4 years, 8 months ago by yzshen1

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@27_watcher_no_abort

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Draft] See what tests are broken. BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Make StrongBinding a message loop destruction observer #

Patch Set 4 : #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	mojo/public/cpp/system/tests/watcher_unittest.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	mojo/public/cpp/system/watcher.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 1925463002 Patch 1