Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19251002: move SafariImporter::CanImport to common (Closed)

Created:
7 years, 5 months ago by scottmg
Modified:
7 years, 5 months ago
Reviewers:
gab, jam
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

move SafariImporter::CanImport to common Split out from https://codereview.chromium.org/18501013/ and that must be landed first. TBR=gab@chromium.org BUG=254672, 237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211881

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : remove unnecessary DEPS #

Total comments: 4

Patch Set 4 : . #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -36 lines) Patch
M chrome/browser/DEPS View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/importer/importer_list.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/common/importer/safari_importer_utils.h View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/common/importer/safari_importer_utils.mm View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/utility/importer/safari_importer.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/utility/importer/safari_importer.mm View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/utility/importer/safari_importer_unittest.mm View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
7 years, 5 months ago (2013-07-15 17:46:12 UTC) #1
jam
https://codereview.chromium.org/19251002/diff/2001/chrome/browser/DEPS File chrome/browser/DEPS (right): https://codereview.chromium.org/19251002/diff/2001/chrome/browser/DEPS#newcode77 chrome/browser/DEPS:77: "-chrome/utility", this line isn't needed since chrome/browser can't get ...
7 years, 5 months ago (2013-07-15 19:49:05 UTC) #2
scottmg
thanks https://codereview.chromium.org/19251002/diff/2001/chrome/browser/DEPS File chrome/browser/DEPS (right): https://codereview.chromium.org/19251002/diff/2001/chrome/browser/DEPS#newcode77 chrome/browser/DEPS:77: "-chrome/utility", On 2013/07/15 19:49:05, jam wrote: > this ...
7 years, 5 months ago (2013-07-15 20:03:19 UTC) #3
gab
lgtm w/ nits Thanks! Gab https://codereview.chromium.org/19251002/diff/6001/chrome/chrome_common.gypi File chrome/chrome_common.gypi (right): https://codereview.chromium.org/19251002/diff/6001/chrome/chrome_common.gypi#newcode358 chrome/chrome_common.gypi:358: 'common/importer/safari_importer_utils.mm', nit: .mm comes ...
7 years, 5 months ago (2013-07-16 14:18:05 UTC) #4
scottmg
https://codereview.chromium.org/19251002/diff/6001/chrome/chrome_common.gypi File chrome/chrome_common.gypi (right): https://codereview.chromium.org/19251002/diff/6001/chrome/chrome_common.gypi#newcode358 chrome/chrome_common.gypi:358: 'common/importer/safari_importer_utils.mm', On 2013/07/16 14:18:06, gab wrote: > nit: .mm ...
7 years, 5 months ago (2013-07-16 16:11:32 UTC) #5
scottmg
tbr jam for removing unnecessary chrome/browser/DEPS entry
7 years, 5 months ago (2013-07-17 00:20:17 UTC) #6
scottmg
7 years, 5 months ago (2013-07-17 00:20:52 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 manually as r211881 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698