Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: chrome/utility/importer/safari_importer_unittest.mm

Issue 19251002: move SafariImporter::CanImport to common (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/utility/importer/safari_importer.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/utility/importer/safari_importer.h" 5 #include "chrome/utility/importer/safari_importer.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/files/scoped_temp_dir.h" 10 #include "base/files/scoped_temp_dir.h"
11 #include "base/path_service.h" 11 #include "base/path_service.h"
12 #include "base/strings/string16.h" 12 #include "base/strings/string16.h"
13 #include "base/strings/string_util.h" 13 #include "base/strings/string_util.h"
14 #include "base/strings/sys_string_conversions.h" 14 #include "base/strings/sys_string_conversions.h"
15 #include "base/strings/utf_string_conversions.h" 15 #include "base/strings/utf_string_conversions.h"
16 #include "chrome/common/chrome_paths.h" 16 #include "chrome/common/chrome_paths.h"
17 #include "chrome/common/importer/imported_bookmark_entry.h" 17 #include "chrome/common/importer/imported_bookmark_entry.h"
18 #include "chrome/common/importer/imported_favicon_usage.h" 18 #include "chrome/common/importer/imported_favicon_usage.h"
19 #include "chrome/common/importer/importer_bridge.h" 19 #include "chrome/common/importer/importer_bridge.h"
20 #include "chrome/common/importer/safari_importer_utils.h"
20 #include "chrome/utility/importer/safari_importer.h" 21 #include "chrome/utility/importer/safari_importer.h"
21 #include "sql/connection.h" 22 #include "sql/connection.h"
22 #include "testing/platform_test.h" 23 #include "testing/platform_test.h"
23 24
24 // In order to test the Safari import functionality effectively, we store a 25 // In order to test the Safari import functionality effectively, we store a
25 // simulated Library directory containing dummy data files in the same 26 // simulated Library directory containing dummy data files in the same
26 // structure as ~/Library in the Chrome test data directory. 27 // structure as ~/Library in the Chrome test data directory.
27 // This function returns the path to that directory. 28 // This function returns the path to that directory.
28 base::FilePath GetTestSafariLibraryPath() { 29 base::FilePath GetTestSafariLibraryPath() {
29 base::FilePath test_dir; 30 base::FilePath test_dir;
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 EXPECT_TRUE(fav1.urls.find(GURL("http://www.opensearch.org/Home")) 181 EXPECT_TRUE(fav1.urls.find(GURL("http://www.opensearch.org/Home"))
181 != fav1.urls.end()); 182 != fav1.urls.end());
182 183
183 EXPECT_TRUE(fav1.urls.find( 184 EXPECT_TRUE(fav1.urls.find(
184 GURL("http://www.opensearch.org/Special:Search?search=lalala&go=Search")) 185 GURL("http://www.opensearch.org/Special:Search?search=lalala&go=Search"))
185 != fav1.urls.end()); 186 != fav1.urls.end());
186 } 187 }
187 188
188 TEST_F(SafariImporterTest, CanImport) { 189 TEST_F(SafariImporterTest, CanImport) {
189 uint16 items = importer::NONE; 190 uint16 items = importer::NONE;
190 EXPECT_TRUE(SafariImporter::CanImport(GetTestSafariLibraryPath(), &items)); 191 EXPECT_TRUE(SafariImporterCanImport(GetTestSafariLibraryPath(), &items));
191 EXPECT_EQ(items, importer::HISTORY | importer::FAVORITES); 192 EXPECT_EQ(items, importer::HISTORY | importer::FAVORITES);
192 EXPECT_EQ(items & importer::COOKIES, importer::NONE); 193 EXPECT_EQ(items & importer::COOKIES, importer::NONE);
193 EXPECT_EQ(items & importer::PASSWORDS, importer::NONE); 194 EXPECT_EQ(items & importer::PASSWORDS, importer::NONE);
194 EXPECT_EQ(items & importer::SEARCH_ENGINES, importer::NONE); 195 EXPECT_EQ(items & importer::SEARCH_ENGINES, importer::NONE);
195 EXPECT_EQ(items & importer::HOME_PAGE, importer::NONE); 196 EXPECT_EQ(items & importer::HOME_PAGE, importer::NONE);
196 197
197 // Check that we don't import anything from a bogus library directory. 198 // Check that we don't import anything from a bogus library directory.
198 base::ScopedTempDir fake_library_dir; 199 base::ScopedTempDir fake_library_dir;
199 ASSERT_TRUE(fake_library_dir.CreateUniqueTempDir()); 200 ASSERT_TRUE(fake_library_dir.CreateUniqueTempDir());
200 EXPECT_FALSE(SafariImporter::CanImport(fake_library_dir.path(), &items)); 201 EXPECT_FALSE(SafariImporterCanImport(fake_library_dir.path(), &items));
201 } 202 }
OLDNEW
« no previous file with comments | « chrome/utility/importer/safari_importer.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698