RenderText: Don't default-construct gfx::Fonts unnecessarily

RenderText: Don't default-construct gfx::Fonts unnecessarily

The default constructor for gfx::Font is expensive. Don't use it when
creating text runs. Instead, reference an existing font.

RenderTextMac doesn't need the gfx::Font at all, so just retain the
CTFont on the run, since constructing a gfx::Font from an NSFont is also
expensive.

BUG=605131
Committed: https://crrev.com/45d205ff3d72b742b3c3d16c66d6074800e86baf
Cr-Commit-Position: refs/heads/master@{#390556}

[tapted, 2016-04-28 08:55:46]

Description was changed from

==========
RenderText: Don't default-construct gfx::Fonts unnecessarily

The default constructor for gfx::Font is expensive. Don't use it when
creating text runs. Instead, reference an existing font.

BUG=
==========

to

==========
RenderText: Don't default-construct gfx::Fonts unnecessarily

The default constructor for gfx::Font is expensive. Don't use it when
creating text runs. Instead, reference an existing font.

BUG=605131
==========

[tapted, 2016-04-28 14:33:52]

Description was changed from

==========
RenderText: Don't default-construct gfx::Fonts unnecessarily

The default constructor for gfx::Font is expensive. Don't use it when
creating text runs. Instead, reference an existing font.

BUG=605131
==========

to

==========
RenderText: Don't default-construct gfx::Fonts unnecessarily

The default constructor for gfx::Font is expensive. Don't use it when
creating text runs. Instead, reference an existing font.

RenderTextMac doesn't need the gfx::Font at all, so just retain the
CTFont on the run, since constructing a gfx::Font from an NSFont is also
expensive.

BUG=605131
==========

[tapted, 2016-04-28 14:33:53]

tapted@chromium.org changed reviewers:
+ asvitkine@chromium.org

[tapted, 2016-04-28 14:34:52]

Hi Alexei - please take a look - this was the next biggest culprit from the
traces in http://crbug.com/605131

[Alexei Svitkine (slow), 2016-04-28 15:12:20]

lgtm

[tapted, 2016-04-29 00:13:31]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-04-29 00:13:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925033002/20001

[commit-bot: I haz the power, 2016-04-29 01:23:30]

Description was changed from

==========
RenderText: Don't default-construct gfx::Fonts unnecessarily

The default constructor for gfx::Font is expensive. Don't use it when
creating text runs. Instead, reference an existing font.

RenderTextMac doesn't need the gfx::Font at all, so just retain the
CTFont on the run, since constructing a gfx::Font from an NSFont is also
expensive.

BUG=605131
==========

to

==========
RenderText: Don't default-construct gfx::Fonts unnecessarily

The default constructor for gfx::Font is expensive. Don't use it when
creating text runs. Instead, reference an existing font.

RenderTextMac doesn't need the gfx::Font at all, so just retain the
CTFont on the run, since constructing a gfx::Font from an NSFont is also
expensive.

BUG=605131
==========

[commit-bot: I haz the power, 2016-04-29 01:23:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:23:17]

Patchset 2 (id:??) landed as
https://crrev.com/45d205ff3d72b742b3c3d16c66d6074800e86baf
Cr-Commit-Position: refs/heads/master@{#390556}

[commit-bot: I haz the power, 2016-04-30 17:58:45]

Description was changed from

==========
RenderText: Don't default-construct gfx::Fonts unnecessarily

The default constructor for gfx::Font is expensive. Don't use it when
creating text runs. Instead, reference an existing font.

RenderTextMac doesn't need the gfx::Font at all, so just retain the
CTFont on the run, since constructing a gfx::Font from an NSFont is also
expensive.

BUG=605131
==========

to

==========
RenderText: Don't default-construct gfx::Fonts unnecessarily

The default constructor for gfx::Font is expensive. Don't use it when
creating text runs. Instead, reference an existing font.

RenderTextMac doesn't need the gfx::Font at all, so just retain the
CTFont on the run, since constructing a gfx::Font from an NSFont is also
expensive.

BUG=605131

Committed: https://crrev.com/45d205ff3d72b742b3c3d16c66d6074800e86baf
Cr-Commit-Position: refs/heads/master@{#390556}
==========