ui/gfx/render_text_mac.h - Issue 1925033002: RenderText: Don't default-construct gfx::Fonts unnecessarily

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_mac.h

Issue 1925033002: RenderText: Don't default-construct gfx::Fonts unnecessarily (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove gfx::Font from RTM completely Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/render_text_mac.h

diff --git a/ui/gfx/render_text_mac.h b/ui/gfx/render_text_mac.h

index e1dbb6ff8764938d3a379da3c38df96a56cc2823..a437ac57982d140797fa35616c3d5d30389bf81a 100644

--- a/ui/gfx/render_text_mac.h

+++ b/ui/gfx/render_text_mac.h

@@ -68,7 +68,7 @@ class GFX_EXPORT RenderTextMac : public RenderText {

std::vector<uint16_t> glyphs;

std::vector<SkPoint> glyph_positions;

SkScalar width;

- Font font;

+ base::ScopedCFTypeRef<CTFontRef> ct_font;

sk_sp<SkTypeface> typeface;

SkColor foreground;

bool underline;

@@ -76,7 +76,8 @@ class GFX_EXPORT RenderTextMac : public RenderText {

bool diagonal_strike;

TextRun();

- TextRun(const TextRun& other);

+ TextRun(const TextRun& other) = delete;

+ TextRun(TextRun&& other);

~TextRun();

};

« no previous file with comments | « ui/gfx/render_text_harfbuzz.cc ('k') | ui/gfx/render_text_mac.mm » ('j') | no next file with comments »