Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: ui/gfx/render_text_unittest.cc

Issue 1925033002: RenderText: Don't default-construct gfx::Fonts unnecessarily (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove gfx::Font from RTM completely Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/render_text_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_unittest.cc
diff --git a/ui/gfx/render_text_unittest.cc b/ui/gfx/render_text_unittest.cc
index 90d1604a4b86a78f79941cca4700bcd34a0276e8..598240ce4c5acf7a0112bf261b7e1f49791346fa 100644
--- a/ui/gfx/render_text_unittest.cc
+++ b/ui/gfx/render_text_unittest.cc
@@ -2707,7 +2707,7 @@ TEST_F(RenderTextTest, HarfBuzz_Clusters) {
},
};
- internal::TextRunHarfBuzz run;
+ internal::TextRunHarfBuzz run((Font()));
run.range = Range(0, 4);
run.glyph_count = 4;
run.glyph_to_char.resize(4);
@@ -2790,7 +2790,7 @@ TEST_F(RenderTextTest, HarfBuzz_SubglyphGraphemePartition) {
},
};
- internal::TextRunHarfBuzz run;
+ internal::TextRunHarfBuzz run((Font()));
run.range = Range(0, 4);
run.glyph_count = 2;
run.glyph_to_char.resize(2);
@@ -2941,7 +2941,7 @@ TEST_F(RenderTextTest, HarfBuzz_NonExistentFont) {
// Ensure an empty run returns sane values to queries.
TEST_F(RenderTextTest, HarfBuzz_EmptyRun) {
- internal::TextRunHarfBuzz run;
+ internal::TextRunHarfBuzz run((Font()));
const base::string16 kString = ASCIIToUTF16("abcdefgh");
std::unique_ptr<base::i18n::BreakIterator> iter(new base::i18n::BreakIterator(
kString, base::i18n::BreakIterator::BREAK_CHARACTER));
« no previous file with comments | « ui/gfx/render_text_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698