Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1924913002: [DevTools] Move API methods from V8DebuggerAgent to V8InspectorSession. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move API methods from V8DebuggerAgent to V8InspectorSession. BUG=580337 Committed: https://crrev.com/411cc13880053cd4583f350a419092a2a3a0cad5 Cr-Commit-Position: refs/heads/master@{#390291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -97 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 4 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 11 chunks +13 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 8 chunks +8 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 2 chunks +10 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 8 chunks +9 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 2 chunks +53 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ContentSearchUtil.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerAgent.h View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1924663006 Patch 1

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 7 months ago (2016-04-27 21:20:22 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-04-28 01:24:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924913002/1
4 years, 7 months ago (2016-04-28 01:29:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 03:43:51 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:15:59 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/411cc13880053cd4583f350a419092a2a3a0cad5
Cr-Commit-Position: refs/heads/master@{#390291}

Powered by Google App Engine
This is Rietveld 408576698