Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Side by Side Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 1924913002: [DevTools] Move API methods from V8DebuggerAgent to V8InspectorSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 PageConsoleAgent* pageConsoleAgent = PageConsoleAgent::create(runtimeAgent, m_domAgent, m_inspectedFrames.get()); 417 PageConsoleAgent* pageConsoleAgent = PageConsoleAgent::create(runtimeAgent, m_domAgent, m_inspectedFrames.get());
418 m_session->append(pageConsoleAgent); 418 m_session->append(pageConsoleAgent);
419 419
420 InspectorWorkerAgent* workerAgent = InspectorWorkerAgent::create(m_inspected Frames.get(), pageConsoleAgent); 420 InspectorWorkerAgent* workerAgent = InspectorWorkerAgent::create(m_inspected Frames.get(), pageConsoleAgent);
421 m_session->append(workerAgent); 421 m_session->append(workerAgent);
422 422
423 InspectorTracingAgent* tracingAgent = InspectorTracingAgent::create(this, wo rkerAgent, m_inspectedFrames.get()); 423 InspectorTracingAgent* tracingAgent = InspectorTracingAgent::create(this, wo rkerAgent, m_inspectedFrames.get());
424 m_tracingAgent = tracingAgent; 424 m_tracingAgent = tracingAgent;
425 m_session->append(tracingAgent); 425 m_session->append(tracingAgent);
426 426
427 m_session->append(InspectorDOMDebuggerAgent::create(isolate, m_domAgent, run timeAgent, debuggerAgent->v8Agent())); 427 m_session->append(new InspectorDOMDebuggerAgent(isolate, m_domAgent, runtime Agent, m_v8Session.get()));
428 428
429 m_session->append(InspectorInputAgent::create(m_inspectedFrames.get())); 429 m_session->append(InspectorInputAgent::create(m_inspectedFrames.get()));
430 430
431 m_session->append(InspectorProfilerAgent::create(m_v8Session->profilerAgent( ), m_overlay.get())); 431 m_session->append(InspectorProfilerAgent::create(m_v8Session->profilerAgent( ), m_overlay.get()));
432 432
433 m_session->append(InspectorHeapProfilerAgent::create(isolate, m_v8Session->h eapProfilerAgent())); 433 m_session->append(InspectorHeapProfilerAgent::create(isolate, m_v8Session->h eapProfilerAgent()));
434 434
435 InspectorPageAgent* pageAgent = InspectorPageAgent::create(m_inspectedFrames .get(), this, m_resourceContentLoader.get(), debuggerAgent); 435 InspectorPageAgent* pageAgent = InspectorPageAgent::create(m_inspectedFrames .get(), this, m_resourceContentLoader.get(), m_v8Session.get());
436 m_pageAgent = pageAgent; 436 m_pageAgent = pageAgent;
437 m_session->append(pageAgent); 437 m_session->append(pageAgent);
438 438
439 m_tracingAgent->setLayerTreeId(m_layerTreeId); 439 m_tracingAgent->setLayerTreeId(m_layerTreeId);
440 m_resourceAgent->setHostId(hostId); 440 m_resourceAgent->setHostId(hostId);
441 441
442 if (m_includeViewAgents) { 442 if (m_includeViewAgents) {
443 // TODO(dgozman): we should actually pass the view instead of frame, but during 443 // TODO(dgozman): we should actually pass the view instead of frame, but during
444 // remote->local transition we cannot access mainFrameImpl() yet, so we have to store the 444 // remote->local transition we cannot access mainFrameImpl() yet, so we have to store the
445 // frame which will become the main frame later. 445 // frame which will become the main frame later.
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
687 if (!protocol::Dispatcher::getCommandName(message, &commandName)) 687 if (!protocol::Dispatcher::getCommandName(message, &commandName))
688 return false; 688 return false;
689 return commandName == "Debugger.pause" 689 return commandName == "Debugger.pause"
690 || commandName == "Debugger.setBreakpoint" 690 || commandName == "Debugger.setBreakpoint"
691 || commandName == "Debugger.setBreakpointByUrl" 691 || commandName == "Debugger.setBreakpointByUrl"
692 || commandName == "Debugger.removeBreakpoint" 692 || commandName == "Debugger.removeBreakpoint"
693 || commandName == "Debugger.setBreakpointsActive"; 693 || commandName == "Debugger.setBreakpointsActive";
694 } 694 }
695 695
696 } // namespace blink 696 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698