Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

Issue 1924823003: [Findit] Use heuristic analysis result for test try jobs(Findit side). (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Use culprits directly if returned from recipe. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py b/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
index 5befaa6ca78d221191987120ef2e30068f1f1bc4..79262a3edd817d73a1ab802096b9e3ac2c753d52 100644
--- a/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
+++ b/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py
@@ -885,3 +885,48 @@ class IdentifyTryJobCulpritPipelineTest(testing.AppengineTestCase):
result_status.FOUND_UNTRIAGED)
self.assertEqual(analysis.suspected_cls, [suspected_cl])
self.assertEqual(version, analysis.version) # No update to analysis.
+
+ def testFindCulpritForEachTestFailureRevisionNotRun(self):
+ blame_list = ['rev1']
+ result = {
+ 'report': {
+ 'result': {
+ 'rev2': 'passed'
+ }
+ }
+ }
+
+ pipeline = IdentifyTryJobCulpritPipeline()
+ culprit_map, failed_revisions = pipeline._FindCulpritForEachTestFailure(
+ blame_list, result)
+ self.assertEqual(culprit_map, {})
+ self.assertEqual(failed_revisions, [])
+
+ def testFindCulpritForEachTestFailureCulpritsReturned(self):
+ blame_list = ['rev1']
+ result = {
+ 'report': {
+ 'culprits': {
+ 'a_tests': {
+ 'Test1': 'rev1'
+ }
+ }
+ }
+ }
+
+ pipeline = IdentifyTryJobCulpritPipeline()
+ culprit_map, failed_revisions = pipeline._FindCulpritForEachTestFailure(
+ blame_list, result)
+
+ expected_culprit_map = {
+ 'a_tests': {
+ 'tests': {
+ 'Test1': {
+ 'revision': 'rev1'
+ }
+ }
+ }
+ }
+
+ self.assertEqual(culprit_map, expected_culprit_map)
+ self.assertEqual(failed_revisions, ['rev1'])
« no previous file with comments | « appengine/findit/waterfall/schedule_try_job_pipeline.py ('k') | appengine/findit/waterfall/test/try_job_util_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698