appengine/findit/waterfall/schedule_try_job_pipeline.py - Issue 1924823003: [Findit] Use heuristic analysis result for test try jobs(Findit side).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/schedule_try_job_pipeline.py

Issue 1924823003: [Findit] Use heuristic analysis result for test try jobs(Findit side). (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Use culprits directly if returned from recipe. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/identify_try_job_culprit_pipeline.py ('k') | appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/schedule_try_job_pipeline.py

diff --git a/appengine/findit/waterfall/schedule_try_job_pipeline.py b/appengine/findit/waterfall/schedule_try_job_pipeline.py

index a29ca3d4f6c3086a46f3ca90320dec0864b2c727..e157d7a36b3c8494fb4be6408acdf1375d13952f 100644

--- a/appengine/findit/waterfall/schedule_try_job_pipeline.py

+++ b/appengine/findit/waterfall/schedule_try_job_pipeline.py

@@ -32,13 +32,14 @@ class ScheduleTryJobPipeline(BasePipeline):

properties['target_buildername'] = builder_name

if compile_targets:

properties['compile_targets'] = compile_targets

- if suspected_revisions:

- properties['suspected_revisions'] = suspected_revisions

else: # try_job_type is 'test'.

properties['target_testername'] = builder_name

assert targeted_tests

properties['tests'] = targeted_tests

+ if suspected_revisions:

+ properties['suspected_revisions'] = suspected_revisions

return properties

# Arguments number differs from overridden method - pylint: disable=W0221