Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: appengine/findit/waterfall/test/try_job_util_test.py

Issue 1924823003: [Findit] Use heuristic analysis result for test try jobs(Findit side). (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Use culprits directly if returned from recipe. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/try_job_util_test.py
diff --git a/appengine/findit/waterfall/test/try_job_util_test.py b/appengine/findit/waterfall/test/try_job_util_test.py
index 706a8c82916c1adf8d83231a60258153893844ff..d7c671fb8b923379ec6a64a173dbbe0d4e8a217d 100644
--- a/appengine/findit/waterfall/test/try_job_util_test.py
+++ b/appengine/findit/waterfall/test/try_job_util_test.py
@@ -423,7 +423,7 @@ class TryJobUtilTest(wf_testcase.WaterfallTestCase):
signals, 'master1', 'builder1'),
['b.o'])
- def testGetSuspectsForCompileFailureFromHeuristicResult(self):
+ def testGetSuspectsFromHeuristicResultForCompile(self):
heuristic_result = {
'failures': [
{
@@ -437,13 +437,41 @@ class TryJobUtilTest(wf_testcase.WaterfallTestCase):
},
],
},
+ ]
+ }
+ expected_suspected_revisions = ['r1', 'r2']
+ self.assertEqual(
+ expected_suspected_revisions,
+ try_job_util._GetSuspectsFromHeuristicResult(heuristic_result))
+
+ def testGetSuspectsFromHeuristicResultForTest(self):
+ heuristic_result = {
+ 'failures': [
+ {
+ 'step_name': 'step1',
+ 'suspected_cls': [
+ {
+ 'revision': 'r1',
+ },
+ {
+ 'revision': 'r2',
+ },
+ ],
+ },
{
- 'step_name': 'steps'
+ 'step_name': 'step2',
+ 'suspected_cls': [
+ {
+ 'revision': 'r1',
+ },
+ {
+ 'revision': 'r3',
+ },
+ ],
},
]
}
- expected_suspected_revisions = ['r1', 'r2']
+ expected_suspected_revisions = ['r1', 'r2', 'r3']
self.assertEqual(
expected_suspected_revisions,
- try_job_util._GetSuspectsForCompileFailureFromHeuristicResult(
- heuristic_result))
+ try_job_util._GetSuspectsFromHeuristicResult(heuristic_result))
« no previous file with comments | « appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py ('k') | appengine/findit/waterfall/try_job_util.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698