Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1924693003: Rolls BoringSSL forward (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 6 months ago
Reviewers:
Bill Hesse, Ivan Posva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rolls BoringSSL forward to: https://boringssl.googlesource.com/boringssl/+/c880e42ba1c8032d4cdde2aba0541d8a9d9fa2e9 This change also prunes unneeded stuff from our boringssl gyp files. related #26343, #25630, #25256 fixes #25647, #24321 R=iposva@google.com, whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/e954a24e66d9a4b686ba15dc2c124bb49588bff5

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+21401 lines, -8705 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/BUILD.gn View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/boringssl/boringssl.gypi View 17 chunks +20 lines, -17 lines 0 comments Download
M third_party/boringssl/boringssl_configurations.gypi View 2 chunks +0 lines, -107 lines 5 comments Download
M third_party/boringssl/boringssl_dart.gyp View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/boringssl/boringssl_tests.gypi View 8 chunks +106 lines, -0 lines 0 comments Download
M third_party/boringssl/err_data.c View 16 chunks +573 lines, -1993 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/aes/aesv8-armx64.S View 8 chunks +8 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/modes/ghashv8-armx64.S View 9 chunks +16 lines, -13 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/sha/sha1-armv8.S View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/sha/sha256-armv8.S View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/sha/sha512-armv8.S View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/aes/aes-armv4.S View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/aes/aesv8-armx32.S View 8 chunks +8 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/aes/bsaes-armv7.S View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/bn/armv4-mont.S View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/modes/ghash-armv4.S View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/modes/ghashv8-armx32.S View 9 chunks +16 lines, -13 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/sha/sha1-armv4-large.S View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/sha/sha256-armv4.S View 4 chunks +4 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/sha/sha512-armv4.S View 4 chunks +4 lines, -2 lines 0 comments Download
D third_party/boringssl/linux-x86/crypto/cpu-x86-asm.S View 1 chunk +0 lines, -322 lines 0 comments Download
M third_party/boringssl/linux-x86/crypto/sha/sha1-586.S View 7 chunks +1184 lines, -181 lines 0 comments Download
M third_party/boringssl/linux-x86/crypto/sha/sha256-586.S View 6 chunks +1188 lines, -206 lines 0 comments Download
M third_party/boringssl/linux-x86_64/crypto/bn/x86_64-mont5.S View 1 chunk +9 lines, -0 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/cpu-x86_64-asm.S View 1 chunk +0 lines, -143 lines 0 comments Download
D third_party/boringssl/linux-x86_64/crypto/rc4/rc4-md5-x86_64.S View 1 chunk +0 lines, -1262 lines 0 comments Download
M third_party/boringssl/linux-x86_64/crypto/sha/sha1-x86_64.S View 2 chunks +1121 lines, -0 lines 0 comments Download
M third_party/boringssl/linux-x86_64/crypto/sha/sha256-x86_64.S View 2 chunks +1062 lines, -0 lines 0 comments Download
M third_party/boringssl/linux-x86_64/crypto/sha/sha512-x86_64.S View 2 chunks +2241 lines, -0 lines 0 comments Download
D third_party/boringssl/mac-x86/crypto/cpu-x86-asm.S View 1 chunk +0 lines, -309 lines 0 comments Download
M third_party/boringssl/mac-x86/crypto/sha/sha1-586.S View 7 chunks +1181 lines, -178 lines 0 comments Download
M third_party/boringssl/mac-x86/crypto/sha/sha256-586.S View 6 chunks +1188 lines, -206 lines 0 comments Download
M third_party/boringssl/mac-x86_64/crypto/bn/x86_64-mont5.S View 1 chunk +9 lines, -0 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/cpu-x86_64-asm.S View 1 chunk +0 lines, -143 lines 0 comments Download
D third_party/boringssl/mac-x86_64/crypto/rc4/rc4-md5-x86_64.S View 1 chunk +0 lines, -1262 lines 0 comments Download
M third_party/boringssl/mac-x86_64/crypto/sha/sha1-x86_64.S View 2 chunks +1121 lines, -0 lines 0 comments Download
M third_party/boringssl/mac-x86_64/crypto/sha/sha256-x86_64.S View 2 chunks +1062 lines, -0 lines 0 comments Download
M third_party/boringssl/mac-x86_64/crypto/sha/sha512-x86_64.S View 2 chunks +2241 lines, -0 lines 0 comments Download
D third_party/boringssl/win-x86/crypto/cpu-x86-asm.asm View 1 chunk +0 lines, -303 lines 0 comments Download
M third_party/boringssl/win-x86/crypto/sha/sha1-586.asm View 7 chunks +1179 lines, -176 lines 0 comments Download
M third_party/boringssl/win-x86/crypto/sha/sha256-586.asm View 6 chunks +1188 lines, -206 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/bn/x86_64-mont5.asm View 1 chunk +9 lines, -0 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/cpu-x86_64-asm.asm View 1 chunk +0 lines, -154 lines 0 comments Download
D third_party/boringssl/win-x86_64/crypto/rc4/rc4-md5-x86_64.asm View 1 chunk +0 lines, -1372 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/sha/sha1-x86_64.asm View 4 chunks +1152 lines, -0 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/sha/sha256-x86_64.asm View 4 chunks +1088 lines, -0 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/sha/sha512-x86_64.asm View 2 chunks +2401 lines, -100 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
zra
https://codereview.chromium.org/1924693003/diff/1/third_party/boringssl/boringssl_configurations.gypi File third_party/boringssl/boringssl_configurations.gypi (left): https://codereview.chromium.org/1924693003/diff/1/third_party/boringssl/boringssl_configurations.gypi#oldcode7 third_party/boringssl/boringssl_configurations.gypi:7: # This code is C code, not C++, and ...
4 years, 7 months ago (2016-04-27 21:38:52 UTC) #2
Ivan Posva
LGTM -ip
4 years, 7 months ago (2016-04-29 06:05:22 UTC) #5
Bill Hesse
LGTM. Thanks!
4 years, 7 months ago (2016-04-29 13:55:49 UTC) #6
zra
Committed patchset #1 (id:1) manually as e954a24e66d9a4b686ba15dc2c124bb49588bff5 (presubmit successful).
4 years, 7 months ago (2016-04-29 17:00:51 UTC) #8
Bill Hesse
This commit was reverted by https://codereview.chromium.org/1938433002 We have issues with supporting all the C standards ...
4 years, 6 months ago (2016-06-14 11:33:01 UTC) #9
Bill Hesse
4 years, 6 months ago (2016-06-14 11:34:17 UTC) #10
Message was sent while issue was closed.
On 2016/06/14 11:33:01, Bill Hesse wrote:
> This commit was reverted by
> https://codereview.chromium.org/1938433002
> 
> We have issues with supporting all the C standards that BoringSSL relies on -
we
> need to boost our compiler minimum requirements:

The issue tracking this is https://github.com/dart-lang/sdk/issues/26367

Powered by Google App Engine
This is Rietveld 408576698