Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1938433002: Revert BoringSSL Roll (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 6 months ago
Reviewers:
Bill Hesse, Ivan Posva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3342 lines, -21308 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/boringssl/boringssl.gypi View 17 chunks +17 lines, -20 lines 0 comments Download
M third_party/boringssl/boringssl_configurations.gypi View 2 chunks +107 lines, -0 lines 0 comments Download
M third_party/boringssl/boringssl_dart.gyp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/boringssl/boringssl_tests.gypi View 8 chunks +0 lines, -106 lines 0 comments Download
M third_party/boringssl/err_data.c View 16 chunks +1993 lines, -573 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/aes/aesv8-armx64.S View 8 chunks +2 lines, -8 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/modes/ghashv8-armx64.S View 9 chunks +13 lines, -16 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/sha/sha1-armv8.S View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/sha/sha256-armv8.S View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/boringssl/linux-aarch64/crypto/sha/sha512-armv8.S View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/aes/aes-armv4.S View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/aes/aesv8-armx32.S View 8 chunks +2 lines, -8 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/aes/bsaes-armv7.S View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/boringssl/linux-arm/crypto/bn/armv4-mont.S View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/modes/ghash-armv4.S View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/modes/ghashv8-armx32.S View 9 chunks +13 lines, -16 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/sha/sha1-armv4-large.S View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/sha/sha256-armv4.S View 4 chunks +2 lines, -4 lines 0 comments Download
M third_party/boringssl/linux-arm/crypto/sha/sha512-armv4.S View 4 chunks +2 lines, -4 lines 0 comments Download
M third_party/boringssl/linux-x86/crypto/sha/sha1-586.S View 7 chunks +181 lines, -1184 lines 0 comments Download
M third_party/boringssl/linux-x86/crypto/sha/sha256-586.S View 6 chunks +206 lines, -1188 lines 0 comments Download
M third_party/boringssl/linux-x86_64/crypto/bn/x86_64-mont5.S View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/boringssl/linux-x86_64/crypto/sha/sha1-x86_64.S View 2 chunks +0 lines, -1121 lines 0 comments Download
M third_party/boringssl/linux-x86_64/crypto/sha/sha256-x86_64.S View 2 chunks +0 lines, -1062 lines 0 comments Download
M third_party/boringssl/linux-x86_64/crypto/sha/sha512-x86_64.S View 2 chunks +0 lines, -2241 lines 0 comments Download
M third_party/boringssl/mac-x86/crypto/sha/sha1-586.S View 7 chunks +178 lines, -1181 lines 0 comments Download
M third_party/boringssl/mac-x86/crypto/sha/sha256-586.S View 6 chunks +206 lines, -1188 lines 0 comments Download
M third_party/boringssl/mac-x86_64/crypto/bn/x86_64-mont5.S View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/boringssl/mac-x86_64/crypto/sha/sha1-x86_64.S View 2 chunks +0 lines, -1121 lines 0 comments Download
M third_party/boringssl/mac-x86_64/crypto/sha/sha256-x86_64.S View 2 chunks +0 lines, -1062 lines 0 comments Download
M third_party/boringssl/mac-x86_64/crypto/sha/sha512-x86_64.S View 2 chunks +0 lines, -2241 lines 0 comments Download
M third_party/boringssl/win-x86/crypto/sha/sha1-586.asm View 7 chunks +176 lines, -1179 lines 0 comments Download
M third_party/boringssl/win-x86/crypto/sha/sha256-586.asm View 6 chunks +206 lines, -1188 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/bn/x86_64-mont5.asm View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/sha/sha1-x86_64.asm View 4 chunks +0 lines, -1152 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/sha/sha256-x86_64.asm View 4 chunks +0 lines, -1088 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/sha/sha512-x86_64.asm View 3 chunks +7 lines, -2308 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zra
TBR This built and passed tests on Linux/Windows/Android for me locally, but is failing to ...
4 years, 7 months ago (2016-04-29 17:14:17 UTC) #2
zra
Committed patchset #1 (id:1) manually as 66ea8c98d52ecf3af74be4eeedf673c03e8e2393 (presubmit successful).
4 years, 7 months ago (2016-04-29 17:14:37 UTC) #4
zra
On 2016/04/29 17:14:17, zra wrote: > TBR > > This built and passed tests on ...
4 years, 7 months ago (2016-04-29 17:50:37 UTC) #5
zra
On 2016/04/29 17:50:37, zra wrote: > On 2016/04/29 17:14:17, zra wrote: > > TBR > ...
4 years, 7 months ago (2016-04-29 18:15:32 UTC) #6
Bill Hesse
4 years, 6 months ago (2016-06-14 11:34:32 UTC) #7
Message was sent while issue was closed.
On 2016/04/29 18:15:32, zra wrote:
> On 2016/04/29 17:50:37, zra wrote:
> > On 2016/04/29 17:14:17, zra wrote:
> > > TBR
> > > 
> > > This built and passed tests on Linux/Windows/Android for me locally, but
is
> > > failing to build on the bots due to a missing header file stdalign.h. I
will
> > > investigate.
> > 
> > I believe I found the problem. The clang compiler we use is from 2013. We
will
> > have to update it before rolling BoringSSL. I will try to update it to a
more
> > recent version that includes stdalign.h
> 
> I do not appear to have permissions to upload to google storage. I'll file an
> issue on github for this.

This commit reverted 
https://codereview.chromium.org/1924693003/

We have issues with supporting all the C standards that BoringSSL relies on - we
need to boost our compiler minimum requirements:

The issue tracking this is https://github.com/dart-lang/sdk/issues/26367

Powered by Google App Engine
This is Rietveld 408576698