tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html - Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/memory_dump_header_pane.html ('k') | tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html

diff --git a/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html b/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html

index a86a412415e3304bdfe343c2c2bc60ca70f56551..debf307b14d3915e7c8f5ff026004f915b0c5b74 100644

--- a/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html

+++ b/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html

@@ -151,9 +151,9 @@ tr.exportTo('tr.ui.analysis', function() {

symbolEl.style.paddingRight = '4px';

symbolEl.style.cursor = 'help';

symbolEl.style.weight = 'bold';

- titleEl.appendChild(symbolEl);

+ Polymer.dom(titleEl).appendChild(symbolEl);

- titleEl.appendChild(document.createTextNode(title));

+ Polymer.dom(titleEl).appendChild(document.createTextNode(title));

return titleEl;

}

@@ -181,22 +181,22 @@ tr.exportTo('tr.ui.analysis', function() {

this.$.info_bar.message = 'Note: Values displayed in the heavy view ' +

'are lower bounds (except for the root).';

- this.$.view_mode_container.appendChild(tr.ui.b.createSelector(

- this, 'viewMode', 'memoryDumpHeapDetailsPane.viewMode',

- tr.b.MultiDimensionalViewType.TOP_DOWN_TREE_VIEW,

- [

- {

- label: 'Top-down (Tree)',

- value: tr.b.MultiDimensionalViewType.TOP_DOWN_TREE_VIEW

- },

- {

- label: 'Top-down (Heavy)',

- value: tr.b.MultiDimensionalViewType.TOP_DOWN_HEAVY_VIEW

- },

- {

- label: 'Bottom-up (Heavy)',

- value: tr.b.MultiDimensionalViewType.BOTTOM_UP_HEAVY_VIEW

- }

+ Polymer.dom(this.$.view_mode_container).appendChild(

+ tr.ui.b.createSelector(this, 'viewMode',

+ 'memoryDumpHeapDetailsPane.viewMode',

+ tr.b.MultiDimensionalViewType.TOP_DOWN_TREE_VIEW, [

+ {

+ label: 'Top-down (Tree)',

+ value: tr.b.MultiDimensionalViewType.TOP_DOWN_TREE_VIEW

+ },

+ {

+ label: 'Top-down (Heavy)',

+ value: tr.b.MultiDimensionalViewType.TOP_DOWN_HEAVY_VIEW

+ },

+ {

+ label: 'Bottom-up (Heavy)',

+ value: tr.b.MultiDimensionalViewType.BOTTOM_UP_HEAVY_VIEW

+ }

]));