Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1923773002: Merge "Android: SELECT popups should not send notifications if a renderer asked to close it." to M5… (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Merge "Android: SELECT popups should not send notifications if a renderer asked to close it." to M51 branch. A renderer clears references to ExternalPopupMenu when it asks to close (FrameHostMsg_HidePopup). So, another ExternalPopupMenu could receive the notifications. OSX, which is another platform using ExternalPopupMenu, doesn't send notifications on close by FrameHostMsg_HidePopup. BUG=604381 Review URL: https://codereview.chromium.org/1907443004 Cr-Commit-Position: refs/heads/master@{#389409} (cherry picked from commit 6f0358d727bdadf6f485a7b6b78c728054af3665) Committed: https://chromium.googlesource.com/chromium/src/+/d7a063c1fedf1f6ccb6eb9f50a9028bd742652d7

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
tkent
4 years, 7 months ago (2016-04-27 00:04:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7a063c1fedf1f6ccb6eb9f50a9028bd742652d7.

Powered by Google App Engine
This is Rietveld 408576698