content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java - Issue 1923773002: Merge "Android: SELECT popups should not send notifications if a renderer asked to close it." to M5…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java

Issue 1923773002: Merge "Android: SELECT popups should not send notifications if a renderer asked to close it." to M5… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/SelectPopup.java ('k') | content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java

index 09ace74dc548f597eb08c6c5e49a14d56e65a04d..609734f689f8cbaea543b5111f126dcb057df42d 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java

@@ -144,8 +144,13 @@ public class SelectPopupDialog implements SelectPopup {

}

@Override

- public void hide() {

- mListBoxPopup.cancel();

- notifySelection(null);

+ public void hide(boolean sendsCancelMessage) {

+ if (sendsCancelMessage) {

+ mListBoxPopup.cancel();

+ notifySelection(null);

+ } else {

+ mSelectionNotified = true;

+ mListBoxPopup.cancel();

+ }

}