Android: SELECT popups should not send notifications if a renderer asked to close it.

Android: SELECT popups should not send notifications if a renderer asked to close it.

A renderer clears references to ExternalPopupMenu when it asks to close
(FrameHostMsg_HidePopup). So, another ExternalPopupMenu could receive the
notifications.

OSX, which is another platform using ExternalPopupMenu, doesn't send
notifications on close by FrameHostMsg_HidePopup.

BUG=604381
Committed: https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665
Cr-Commit-Position: refs/heads/master@{#389409}

[tkent, 2016-04-21 04:04:14]

Description was changed from

==========
Android: SELECT popups should not send notifications if a renderer asked to
close it.

A renderer clears references to ExternalPopupMenu when it asks to close
(FrameHostMsg_HidePopup). So, another ExternalPopupMenu received the
notifications.

OSX, which is another platform using ExternalPopupMenu, doesn't send
notifications on close by FrameHostMsg_HidePopup.

BUG=604381
==========

to

==========
Android: SELECT popups should not send notifications if a renderer asked to
close it.

A renderer clears references to ExternalPopupMenu when it asks to close
(FrameHostMsg_HidePopup). So, another ExternalPopupMenu could receive the
notifications.

OSX, which is another platform using ExternalPopupMenu, doesn't send
notifications on close by FrameHostMsg_HidePopup.

BUG=604381
==========

[tkent, 2016-04-21 04:20:05]

Patchset #1 (id:1) has been deleted

[tkent, 2016-04-21 04:21:22]

tkent@chromium.org changed reviewers:
+ tedchoc@chromium.org

[tkent, 2016-04-21 04:21:22]

tedchoc@, would you review this please?

[Ted C, 2016-04-21 17:35:25]

lgtm

[tkent, 2016-04-22 04:28:29]

Patchset #3 (id:60001) has been deleted

[tkent, 2016-04-22 05:21:51]

Patchset #2 (id:40001) has been deleted

[tkent, 2016-04-22 07:14:29]

Patchset #2 (id:80001) has been deleted

[tkent, 2016-04-22 07:17:15]

Patch Set 1 was not enough.  I'm sorry!

I realized SelectPopup#hide was called in cases other than render's requests. 
So we need to have two types of |hide| operations; with notification and without
notification.  I uploaded a new patch.

[Ted C, 2016-04-22 16:22:12]

still lgtm w/ nit

https://codereview.chromium.org/1907443004/diff/90001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/1907443004/diff/90001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:2554:
if (mSelectPopup == null)
in java, braces are always required (but you can put the statement and
conditional all on the same line if they fit)

[tkent, 2016-04-25 01:30:27]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-04-25 01:30:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1907443004/#ps100001
(title: "Put if-return in one line")

[commit-bot: I haz the power, 2016-04-25 01:30:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907443004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907443004/100001

[tkent, 2016-04-25 01:30:46]

https://codereview.chromium.org/1907443004/diff/90001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/1907443004/diff/90001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:2554:
if (mSelectPopup == null)
On 2016/04/22 at 16:22:12, Ted C wrote:
> in java, braces are always required (but you can put the statement and
conditional all on the same line if they fit)

Done.

[commit-bot: I haz the power, 2016-04-25 01:34:34]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-04-25 01:35:49]

Description was changed from

==========
Android: SELECT popups should not send notifications if a renderer asked to
close it.

A renderer clears references to ExternalPopupMenu when it asks to close
(FrameHostMsg_HidePopup). So, another ExternalPopupMenu could receive the
notifications.

OSX, which is another platform using ExternalPopupMenu, doesn't send
notifications on close by FrameHostMsg_HidePopup.

BUG=604381
==========

to

==========
Android: SELECT popups should not send notifications if a renderer asked to
close it.

A renderer clears references to ExternalPopupMenu when it asks to close
(FrameHostMsg_HidePopup). So, another ExternalPopupMenu could receive the
notifications.

OSX, which is another platform using ExternalPopupMenu, doesn't send
notifications on close by FrameHostMsg_HidePopup.

BUG=604381

Committed: https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665
Cr-Commit-Position: refs/heads/master@{#389409}
==========

[commit-bot: I haz the power, 2016-04-25 01:35:51]

Patchset 3 (id:??) landed as
https://crrev.com/6f0358d727bdadf6f485a7b6b78c728054af3665
Cr-Commit-Position: refs/heads/master@{#389409}