Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1923613002: Fix a nasty scroll bug for Chrome Now-on-tap feature. Also combine the code paths for Android Webvi… (Closed)

Created:
4 years, 8 months ago by sgurun-gerrit only
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix a nasty scroll bug for Chrome Now-on-tap feature. Also combine the code paths for Android Webview and Chrome. Until now webview and chrome were using separate code paths for copying the snapshot tree. We are now combining both to use the same code. Further moving the tests from android webview to content layer to add coverage for both chrome and webview. BUG=603746 Review URL: https://codereview.chromium.org/1907703002 Cr-Commit-Position: refs/heads/master@{#389374} (cherry picked from commit 98495a3d4de6f2be14a71f675212552b63c71def) Committed: https://chromium.googlesource.com/chromium/src/+/d3859f059d3cc32a156a830d0de3080f3cfe7b48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -448 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java View 3 chunks +1 line, -47 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java View 1 chunk +5 lines, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 4 chunks +9 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 2 chunks +0 lines, -304 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeVersionInfo.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_android.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 6 chunks +27 lines, -36 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentView.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 1 chunk +7 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +32 lines, -23 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 4 chunks +8 lines, -10 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/AccessibilitySnapshotNode.java View 3 chunks +11 lines, -10 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 1 chunk +1 line, -4 lines 0 comments Download
A content/public/android/javatests/src/org/chromium/content/browser/webcontents/AccessibilitySnapshotTest.java View 1 chunk +290 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sgurun-gerrit only
4 years, 8 months ago (2016-04-26 18:47:57 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d3859f059d3cc32a156a830d0de3080f3cfe7b48 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698