Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: content/browser/android/content_view_core_impl.h

Issue 1923613002: Fix a nasty scroll bug for Chrome Now-on-tap feature. Also combine the code paths for Android Webvi… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
6 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 6 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
389 void AttachLayer(scoped_refptr<cc::Layer> layer); 389 void AttachLayer(scoped_refptr<cc::Layer> layer);
390 void RemoveLayer(scoped_refptr<cc::Layer> layer); 390 void RemoveLayer(scoped_refptr<cc::Layer> layer);
391 391
392 void MoveRangeSelectionExtent(const gfx::PointF& extent); 392 void MoveRangeSelectionExtent(const gfx::PointF& extent);
393 393
394 void SelectBetweenCoordinates(const gfx::PointF& base, 394 void SelectBetweenCoordinates(const gfx::PointF& base,
395 const gfx::PointF& extent); 395 const gfx::PointF& extent);
396 396
397 void OnShowUnhandledTapUIIfNeeded(int x_dip, int y_dip); 397 void OnShowUnhandledTapUIIfNeeded(int x_dip, int y_dip);
398 398
399 // returns page density (dpi) X page scale
400 float GetScaleFactor() const;
401 private: 399 private:
402 class ContentViewUserData; 400 class ContentViewUserData;
403 401
404 friend class ContentViewUserData; 402 friend class ContentViewUserData;
405 ~ContentViewCoreImpl() override; 403 ~ContentViewCoreImpl() override;
406 404
407 // WebContentsObserver implementation. 405 // WebContentsObserver implementation.
408 void RenderViewReady() override; 406 void RenderViewReady() override;
409 void RenderViewHostChanged(RenderViewHost* old_host, 407 void RenderViewHostChanged(RenderViewHost* old_host,
410 RenderViewHost* new_host) override; 408 RenderViewHost* new_host) override;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
477 scoped_refptr<GinJavaBridgeDispatcherHost> java_bridge_dispatcher_host_; 475 scoped_refptr<GinJavaBridgeDispatcherHost> java_bridge_dispatcher_host_;
478 476
479 DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl); 477 DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl);
480 }; 478 };
481 479
482 bool RegisterContentViewCore(JNIEnv* env); 480 bool RegisterContentViewCore(JNIEnv* env);
483 481
484 } // namespace content 482 } // namespace content
485 483
486 #endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 484 #endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698