content/public/android/java/src/org/chromium/content_public/browser/WebContents.java - Issue 1923613002: Fix a nasty scroll bug for Chrome Now-on-tap feature. Also combine the code paths for Android Webvi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

Issue 1923613002: Fix a nasty scroll bug for Chrome Now-on-tap feature. Also combine the code paths for Android Webvi… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content_public/browser/AccessibilitySnapshotNode.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/webcontents/AccessibilitySnapshotTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

diff --git a/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java b/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

index adb2e560a7933fedea8536b31ce14bbc98a523ef..b5bf43d9fcdc1649ec0ea9f593078f203b4bf27c 100644

--- a/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

+++ b/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

@@ -297,11 +297,8 @@ public interface WebContents extends Parcelable {

* using the callback

* @param callback The callback to be called when the snapshot is ready. The callback

* cannot be null.

- * @param offsetY The Physical on-screen Y offset amount below the top controls.

- * @param scrollX Horizontal scroll offset in physical pixels

- void requestAccessibilitySnapshot(AccessibilitySnapshotCallback callback, float offsetY,

- float scrollX);

+ void requestAccessibilitySnapshot(AccessibilitySnapshotCallback callback);

/**

* Resumes the current media session.