Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1923403003: Add tests for volatile paths to GrShapeTest (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@emptyshape
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M tests/GrShapeTest.cpp View 1 3 chunks +35 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1927673002 Patch 60001

Dependent Patchsets:

Issue 1929643002 Patch 1
Issue 1929643002 Patch 20001
Issue 1929643002 Patch 40001
Issue 1929643002 Patch 60001

Messages

Total messages: 9 (5 generated)
bsalomon
4 years, 7 months ago (2016-04-27 20:00:38 UTC) #3
robertphillips
lgtm
4 years, 7 months ago (2016-04-27 20:12:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923403003/20001
4 years, 7 months ago (2016-04-27 20:18:22 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 20:30:28 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4eeccc9de7d2381df85d68e0331a40cddf5989b1

Powered by Google App Engine
This is Rietveld 408576698