Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1927673002: Add tests for empty GrShapes. (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : rm extra newline #

Patch Set 4 : typo #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -0 lines) Patch
M tests/GrShapeTest.cpp View 1 2 3 5 chunks +81 lines, -0 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
bsalomon
4 years, 7 months ago (2016-04-27 18:57:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927673002/40001
4 years, 7 months ago (2016-04-27 18:58:17 UTC) #5
robertphillips
lgtm https://codereview.chromium.org/1927673002/diff/60001/tests/GrShapeTest.cpp File tests/GrShapeTest.cpp (right): https://codereview.chromium.org/1927673002/diff/60001/tests/GrShapeTest.cpp#newcode495 tests/GrShapeTest.cpp:495: Is it interesting to test and empty SkRRect ...
4 years, 7 months ago (2016-04-27 19:13:06 UTC) #6
egdaniel
lgtm
4 years, 7 months ago (2016-04-27 19:14:07 UTC) #7
bsalomon
https://codereview.chromium.org/1927673002/diff/60001/tests/GrShapeTest.cpp File tests/GrShapeTest.cpp (right): https://codereview.chromium.org/1927673002/diff/60001/tests/GrShapeTest.cpp#newcode495 tests/GrShapeTest.cpp:495: On 2016/04/27 19:13:06, robertphillips wrote: > Is it interesting ...
4 years, 7 months ago (2016-04-27 19:19:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927673002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927673002/60001
4 years, 7 months ago (2016-04-27 19:19:42 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 19:36:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/409ed73237c1fc42ea49ae89efdc4cddc7b6f600

Powered by Google App Engine
This is Rietveld 408576698