Detect empty (r)rects in GrShape.

Detect empty (r)rects in GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1929643002

Committed: https://skia.googlesource.com/skia/+/5e410b4a68d11a06c331139905171952ef535cf8

[bsalomon, 2016-04-27 20:15:31]

Description was changed from

==========
Detect empty (r)rects in GrShape.
==========

to

==========
Detect empty (r)rects in GrShape.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-04-27 20:17:32]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[robertphillips, 2016-04-27 20:22:26]

lgtm

https://codereview.chromium.org/1929643002/diff/20001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/1929643002/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:565: SkRect emptyRect = SkRect::MakeEmpty();
I don't think this check re emptyRRect is useful here.

[bsalomon, 2016-04-27 20:26:46]

https://codereview.chromium.org/1929643002/diff/20001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/1929643002/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:565: SkRect emptyRect = SkRect::MakeEmpty();
On 2016/04/27 20:22:26, robertphillips wrote:
> I don't think this check re emptyRRect is useful here.

Done.

[bsalomon, 2016-04-27 20:26:50]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-04-27 20:26:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1929643002/#ps40001
(title: "remove copy pasta assert")

[commit-bot: I haz the power, 2016-04-27 20:27:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 20:27:02]

This CL has an open dependency (Issue 1923403003 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[egdaniel, 2016-04-28 13:06:10]

https://codereview.chromium.org/1929643002/diff/40001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/1929643002/diff/40001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:557: // A shape made from a empty rrect should behave the
same as an empty path.
picky nit: a -> an

[bsalomon, 2016-04-28 14:20:10]

https://codereview.chromium.org/1929643002/diff/40001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/1929643002/diff/40001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:557: // A shape made from a empty rrect should behave the
same as an empty path.
On 2016/04/28 13:06:10, egdaniel wrote:
> picky nit: a -> an

Done.

[bsalomon, 2016-04-28 14:20:20]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-04-28 14:20:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1929643002/#ps60001
(title: "a->an")

[commit-bot: I haz the power, 2016-04-28 14:20:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929643002/60001

[commit-bot: I haz the power, 2016-04-28 16:30:48]

Description was changed from

==========
Detect empty (r)rects in GrShape.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Detect empty (r)rects in GrShape.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/5e410b4a68d11a06c331139905171952ef535cf8
==========

[commit-bot: I haz the power, 2016-04-28 16:30:49]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/5e410b4a68d11a06c331139905171952ef535cf8