Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1929643002: Detect empty (r)rects in GrShape. (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@volatileshape
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : remove copy pasta assert #

Total comments: 2

Patch Set 4 : a->an #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -9 lines) Patch
M src/gpu/GrShape.h View 1 4 chunks +34 lines, -8 lines 0 comments Download
M tests/GrShapeTest.cpp View 1 2 3 1 chunk +14 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (8 generated)
bsalomon
4 years, 7 months ago (2016-04-27 20:17:32 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/1929643002/diff/20001/tests/GrShapeTest.cpp File tests/GrShapeTest.cpp (right): https://codereview.chromium.org/1929643002/diff/20001/tests/GrShapeTest.cpp#newcode565 tests/GrShapeTest.cpp:565: SkRect emptyRect = SkRect::MakeEmpty(); I don't think this ...
4 years, 7 months ago (2016-04-27 20:22:26 UTC) #4
bsalomon
https://codereview.chromium.org/1929643002/diff/20001/tests/GrShapeTest.cpp File tests/GrShapeTest.cpp (right): https://codereview.chromium.org/1929643002/diff/20001/tests/GrShapeTest.cpp#newcode565 tests/GrShapeTest.cpp:565: SkRect emptyRect = SkRect::MakeEmpty(); On 2016/04/27 20:22:26, robertphillips wrote: ...
4 years, 7 months ago (2016-04-27 20:26:46 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1923403003 Patch 20001). Please resolve the dependency and ...
4 years, 7 months ago (2016-04-27 20:27:02 UTC) #9
egdaniel
https://codereview.chromium.org/1929643002/diff/40001/tests/GrShapeTest.cpp File tests/GrShapeTest.cpp (right): https://codereview.chromium.org/1929643002/diff/40001/tests/GrShapeTest.cpp#newcode557 tests/GrShapeTest.cpp:557: // A shape made from a empty rrect should ...
4 years, 7 months ago (2016-04-28 13:06:10 UTC) #10
bsalomon
https://codereview.chromium.org/1929643002/diff/40001/tests/GrShapeTest.cpp File tests/GrShapeTest.cpp (right): https://codereview.chromium.org/1929643002/diff/40001/tests/GrShapeTest.cpp#newcode557 tests/GrShapeTest.cpp:557: // A shape made from a empty rrect should ...
4 years, 7 months ago (2016-04-28 14:20:10 UTC) #11
bsalomon
4 years, 7 months ago (2016-04-28 14:20:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929643002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929643002/60001
4 years, 7 months ago (2016-04-28 14:20:28 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 16:30:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/5e410b4a68d11a06c331139905171952ef535cf8

Powered by Google App Engine
This is Rietveld 408576698