Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1923143005: service worker: Bump update time even when the script was identical (Closed)

Created:
4 years, 7 months ago by Nate Chapin
Modified:
4 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

service worker: Bump update time even when the script was identical This regressed in https://chromium.googlesource.com/chromium/src/+/57ebec5b7cce00100000763371c56bc4991b56dd Also make the unit test more thorough and realistic: * It was using StopWorker() when the script was identical, but after the change above production doesn't take that path * don't use force_bypass_cache_for_scripts since in production that's only used by DevTools BUG=605382 Review URL: https://codereview.chromium.org/1903043005 Cr-Commit-Position: refs/heads/master@{#389025} (cherry picked from commit 82b3853597f585e25ba051cb6b1ac9063430883f) Committed: https://chromium.googlesource.com/chromium/src/+/e17714d7cfd6cb4de0e2bc38ff5ba269290d58e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -36 lines) Patch
M content/browser/service_worker/embedded_worker_instance.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 6 chunks +29 lines, -22 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 3 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Nate Chapin
Committed patchset #1 (id:1) manually as e17714d7cfd6cb4de0e2bc38ff5ba269290d58e9.
4 years, 7 months ago (2016-04-27 19:02:01 UTC) #2
falken
4 years, 7 months ago (2016-04-28 02:27:23 UTC) #4
Message was sent while issue was closed.
lgtm, thanks for merging.

Powered by Google App Engine
This is Rietveld 408576698