Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1903043005:
service worker: Bump update time even when the script was identical (Closed)
|
Created:
4 years, 8 months ago by falken Modified:
4 years, 8 months ago Reviewers:
nhiroki CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionservice worker: Bump update time even when the script was identical
This regressed in https://chromium.googlesource.com/chromium/src/+/57ebec5b7cce00100000763371c56bc4991b56dd
Also make the unit test more thorough and realistic:
* It was using StopWorker() when the script was identical, but after the change above
production doesn't take that path
* don't use force_bypass_cache_for_scripts since in production that's only used
by DevTools
BUG=605382
Committed: https://crrev.com/82b3853597f585e25ba051cb6b1ac9063430883f
Cr-Commit-Position: refs/heads/master@{#389025}
Patch Set 1 #Patch Set 2 : fix asan #
Messages
Total messages: 32 (16 generated)
falken@chromium.org changed reviewers: + nhiroki@chromium.org
PTAL
Description was changed from ========== service worker: Bump update time even when the script was identical This regressed in https://chromium.googlesource.com/chromium/src/+/57ebec5b7cce00100000763371c5... Also make the unit test more thorough and realistic. It shouldn't use force_bypass_cache_for_scripts since in production that's only used by DevTools. BUG=605382 ========== to ========== service worker: Bump update time even when the script was identical This regressed in https://chromium.googlesource.com/chromium/src/+/57ebec5b7cce00100000763371c5... Also make the unit test more thorough and realistic: * It was using StopWorker() when the script was identical, but after the change above production doesn't take that path * don't use force_bypass_cache_for_scripts since in production that's only used by DevTools BUG=605382 ==========
lgtm
The CQ bit was checked by falken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903043005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by falken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903043005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by falken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903043005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by falken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903043005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
ASAN caught an error that looks possible in the wild too. When EWInstance calls OnScriptLoaded on its observers, and SWRegisterJob::OnScriptLoaded will doom and unset the version, which could cause it to be destroyed.
The CQ bit was checked by falken@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org Link to the patchset: https://codereview.chromium.org/1903043005/#ps20001 (title: "fix asan")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903043005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903043005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by falken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903043005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903043005/20001
Message was sent while issue was closed.
Description was changed from ========== service worker: Bump update time even when the script was identical This regressed in https://chromium.googlesource.com/chromium/src/+/57ebec5b7cce00100000763371c5... Also make the unit test more thorough and realistic: * It was using StopWorker() when the script was identical, but after the change above production doesn't take that path * don't use force_bypass_cache_for_scripts since in production that's only used by DevTools BUG=605382 ========== to ========== service worker: Bump update time even when the script was identical This regressed in https://chromium.googlesource.com/chromium/src/+/57ebec5b7cce00100000763371c5... Also make the unit test more thorough and realistic: * It was using StopWorker() when the script was identical, but after the change above production doesn't take that path * don't use force_bypass_cache_for_scripts since in production that's only used by DevTools BUG=605382 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== service worker: Bump update time even when the script was identical This regressed in https://chromium.googlesource.com/chromium/src/+/57ebec5b7cce00100000763371c5... Also make the unit test more thorough and realistic: * It was using StopWorker() when the script was identical, but after the change above production doesn't take that path * don't use force_bypass_cache_for_scripts since in production that's only used by DevTools BUG=605382 ========== to ========== service worker: Bump update time even when the script was identical This regressed in https://chromium.googlesource.com/chromium/src/+/57ebec5b7cce00100000763371c5... Also make the unit test more thorough and realistic: * It was using StopWorker() when the script was identical, but after the change above production doesn't take that path * don't use force_bypass_cache_for_scripts since in production that's only used by DevTools BUG=605382 Committed: https://crrev.com/82b3853597f585e25ba051cb6b1ac9063430883f Cr-Commit-Position: refs/heads/master@{#389025} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/82b3853597f585e25ba051cb6b1ac9063430883f Cr-Commit-Position: refs/heads/master@{#389025} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
