Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 1923143005: service worker: Bump update time even when the script was identical (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/embedded_worker_instance.cc
diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc
index 1271bc4b856ad95f15873ad880da1a741e5eb018..7456d76d8364e8537c4e993706c81e1e84e7866b 100644
--- a/content/browser/service_worker/embedded_worker_instance.cc
+++ b/content/browser/service_worker/embedded_worker_instance.cc
@@ -508,8 +508,9 @@ void EmbeddedWorkerInstance::OnScriptReadFinished() {
}
void EmbeddedWorkerInstance::OnScriptLoaded() {
- FOR_EACH_OBSERVER(Listener, listener_list_, OnScriptLoaded());
starting_phase_ = SCRIPT_LOADED;
+ FOR_EACH_OBSERVER(Listener, listener_list_, OnScriptLoaded());
+ // |this| may be destroyed by the callback.
}
void EmbeddedWorkerInstance::OnThreadStarted(int thread_id) {
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698