Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1922783002: Move gfx::Display/Screen to display::Display/Screen in aura/events (Closed)

Created:
4 years, 8 months ago by oshima
Modified:
4 years, 8 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul, ozone-reviews_chromium.org, oshima+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move gfx::Display/Screen to display::Display/Screen in aura/events BUG=597761 Committed: https://crrev.com/5245e49945dedbf23f84591130ebddec4688be9b Cr-Commit-Position: refs/heads/master@{#389806}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -130 lines) Patch
M ui/aura/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/aura/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/client/cursor_client.h View 2 chunks +5 lines, -1 line 1 comment Download
M ui/aura/client/screen_position_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/aura_test_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/test/test_cursor_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_cursor_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/test/test_screen.h View 3 chunks +18 lines, -17 lines 0 comments Download
M ui/aura/test/test_screen.cc View 4 chunks +19 lines, -19 lines 0 comments Download
M ui/aura/window.h View 2 chunks +8 lines, -1 line 0 comments Download
M ui/aura/window.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/aura/window_tree_host.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/aura/window_tree_host_platform.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window_tree_host_x11.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M ui/aura/window_unittest.cc View 9 chunks +20 lines, -19 lines 0 comments Download
M ui/events/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/events/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/devices/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/devices/device_data_manager.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/events/devices/x11/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/devices/x11/device_data_manager_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/event_utils.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M ui/events/events.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_configuration_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_configuration_default.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider_config_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/ozone/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/ozone/chromeos/cursor_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/events/ozone/chromeos/cursor_controller.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M ui/events/ozone/chromeos/cursor_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/events/x/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/x/events_x.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/x/events_x_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/snapshot/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/snapshot/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/snapshot/snapshot.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/snapshot/snapshot_android.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922783002/20001
4 years, 8 months ago (2016-04-26 01:14:39 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922783002/40001
4 years, 8 months ago (2016-04-26 01:34:43 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/180412)
4 years, 8 months ago (2016-04-26 03:47:52 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922783002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922783002/60001
4 years, 8 months ago (2016-04-26 06:03:07 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 06:58:51 UTC) #12
oshima
4 years, 8 months ago (2016-04-26 07:18:20 UTC) #15
oshima
https://codereview.chromium.org/1922783002/diff/60001/ui/aura/client/cursor_client.h File ui/aura/client/cursor_client.h (right): https://codereview.chromium.org/1922783002/diff/60001/ui/aura/client/cursor_client.h#newcode19 ui/aura/client/cursor_client.h:19: } This is temporary and will be merged when ...
4 years, 8 months ago (2016-04-26 07:20:47 UTC) #16
sadrul
lgtm
4 years, 8 months ago (2016-04-26 16:38:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922783002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922783002/60001
4 years, 8 months ago (2016-04-26 16:42:22 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 8 months ago (2016-04-26 16:48:10 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 16:50:04 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5245e49945dedbf23f84591130ebddec4688be9b
Cr-Commit-Position: refs/heads/master@{#389806}

Powered by Google App Engine
This is Rietveld 408576698