@deprecated should work on 'called' objects

@deprecated should work on 'called' objects

BUG=https://github.com/dart-lang/sdk/issues/9470

Example output:

$ cat -n a.dart
     1  class Foo {
     2    Foo foo;
     3
     4    @deprecated
     5    call(String name) {
     6      print("hello $name");
     7    }
     8  }
     9
    10  void main() {
    11    Foo f = new Foo();
    12    f("Thomas");
    13    f.foo = new Foo();
    14    f.foo("Timmy");
    15  }
$ xcodebuild/ReleaseX64/dart-sdk/bin/dartanalyzer a.dart
Analyzing [a.dart]...
[hint] 'Foo.call' is deprecated (/Users/srawlins/code/dart-repo3/sdk/a.dart, line 12, col 3)
[hint] 'Foo.call' is deprecated (/Users/srawlins/code/dart-repo3/sdk/a.dart, line 14, col 3)
2 hints found.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/2cfa9c4665d1565bb762671c628d7ee2edf5fccc

[srawlins, 2016-04-25 23:21:20]

Description was changed from

==========
@deprecated should work on 'called' objects

BUG=https://github.com/dart-lang/sdk/issues/9470
==========

to

==========
@deprecated should work on 'called' objects

BUG=https://github.com/dart-lang/sdk/issues/9470

Example output:

$ cat -n a.dart
     1  class Foo {
     2    Foo foo;
     3
     4    @deprecated
     5    call(String name) {
     6      print("hello $name");
     7    }
     8  }
     9
    10  void main() {
    11    Foo f = new Foo();
    12    f("Thomas");
    13    f.foo = new Foo();
    14    f.foo("Timmy");
    15  }
$ xcodebuild/ReleaseX64/dart-sdk/bin/dartanalyzer a.dart
Analyzing [a.dart]...
[hint] 'Foo.call' is deprecated (/Users/srawlins/code/dart-repo3/sdk/a.dart,
line 12, col 3)
[hint] 'Foo.call' is deprecated (/Users/srawlins/code/dart-repo3/sdk/a.dart,
line 14, col 3)
2 hints found.
==========

[srawlins, 2016-04-26 14:51:45]

srawlins@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2016-04-26 15:25:28]

lgtm

https://codereview.chromium.org/1922563003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1922563003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:554: } else if (element.displayName
== FunctionElement.CALL_METHOD_NAME &&
"element.displayName" --> "displayName"

[scheglov, 2016-04-26 15:54:20]

https://codereview.chromium.org/1922563003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1922563003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:251:
FunctionElement.CALL_METHOD_NAME, _currentLibrary);
I'm concerned that we perform method lookup multiple times.
We must do this somewhere else already (and e.g. report that the variable is not
a function).

[srawlins, 2016-04-26 18:55:59]

https://codereview.chromium.org/1922563003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1922563003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:251:
FunctionElement.CALL_METHOD_NAME, _currentLibrary);
On 2016/04/26 15:54:19, scheglov wrote:
> I'm concerned that we perform method lookup multiple times.
> We must do this somewhere else already (and e.g. report that the variable is
not
> a function).

Maybe... element_resolver.dart is where INVOCATION_OF_NON_FUNCTION is generated.
_isExecutableType is where we do this lookupMethod() already.

Are you suggesting that I move this check out of BestPracticesVerifier? I'm all
for simplifying this, so that BestPracticesVerifier doesn't need this
_currentLibrary, but I don't see how.

[scheglov, 2016-04-27 16:12:19]

LGTM

https://codereview.chromium.org/1922563003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1922563003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:251:
FunctionElement.CALL_METHOD_NAME, _currentLibrary);
On 2016/04/26 18:55:59, srawlins wrote:
> On 2016/04/26 15:54:19, scheglov wrote:
> > I'm concerned that we perform method lookup multiple times.
> > We must do this somewhere else already (and e.g. report that the variable is
> not
> > a function).
> 
> Maybe... element_resolver.dart is where INVOCATION_OF_NON_FUNCTION is
generated.
> _isExecutableType is where we do this lookupMethod() already.

  Yes, that's where I thought we could put the check.
  But maybe it does not worth it.

> 
> Are you suggesting that I move this check out of BestPracticesVerifier? I'm
all
> for simplifying this, so that BestPracticesVerifier doesn't need this
> _currentLibrary, but I don't see how.

[srawlins, 2016-04-27 19:53:50]

https://codereview.chromium.org/1922563003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1922563003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:251:
FunctionElement.CALL_METHOD_NAME, _currentLibrary);
On 2016/04/27 16:12:19, scheglov wrote:
> On 2016/04/26 18:55:59, srawlins wrote:
> > On 2016/04/26 15:54:19, scheglov wrote:
> > > I'm concerned that we perform method lookup multiple times.
> > > We must do this somewhere else already (and e.g. report that the variable
is
> > not
> > > a function).
> > 
> > Maybe... element_resolver.dart is where INVOCATION_OF_NON_FUNCTION is
> generated.
> > _isExecutableType is where we do this lookupMethod() already.
> 
>   Yes, that's where I thought we could put the check.
>   But maybe it does not worth it.
> 
> > 
> > Are you suggesting that I move this check out of BestPracticesVerifier? I'm
> all
> > for simplifying this, so that BestPracticesVerifier doesn't need this
> > _currentLibrary, but I don't see how.
> 

Acknowledged.

https://codereview.chromium.org/1922563003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:554: } else if (element.displayName
== FunctionElement.CALL_METHOD_NAME &&
On 2016/04/26 15:25:28, Brian Wilkerson wrote:
> "element.displayName" --> "displayName"

Done.

[srawlins, 2016-04-27 20:40:11]

Description was changed from

==========
@deprecated should work on 'called' objects

BUG=https://github.com/dart-lang/sdk/issues/9470

Example output:

$ cat -n a.dart
     1  class Foo {
     2    Foo foo;
     3
     4    @deprecated
     5    call(String name) {
     6      print("hello $name");
     7    }
     8  }
     9
    10  void main() {
    11    Foo f = new Foo();
    12    f("Thomas");
    13    f.foo = new Foo();
    14    f.foo("Timmy");
    15  }
$ xcodebuild/ReleaseX64/dart-sdk/bin/dartanalyzer a.dart
Analyzing [a.dart]...
[hint] 'Foo.call' is deprecated (/Users/srawlins/code/dart-repo3/sdk/a.dart,
line 12, col 3)
[hint] 'Foo.call' is deprecated (/Users/srawlins/code/dart-repo3/sdk/a.dart,
line 14, col 3)
2 hints found.
==========

to

==========
@deprecated should work on 'called' objects

BUG=https://github.com/dart-lang/sdk/issues/9470

Example output:

$ cat -n a.dart
     1  class Foo {
     2    Foo foo;
     3
     4    @deprecated
     5    call(String name) {
     6      print("hello $name");
     7    }
     8  }
     9
    10  void main() {
    11    Foo f = new Foo();
    12    f("Thomas");
    13    f.foo = new Foo();
    14    f.foo("Timmy");
    15  }
$ xcodebuild/ReleaseX64/dart-sdk/bin/dartanalyzer a.dart
Analyzing [a.dart]...
[hint] 'Foo.call' is deprecated (/Users/srawlins/code/dart-repo3/sdk/a.dart,
line 12, col 3)
[hint] 'Foo.call' is deprecated (/Users/srawlins/code/dart-repo3/sdk/a.dart,
line 14, col 3)
2 hints found.

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2cfa9c4665d1565bb762671c628d7ee2edf5fccc
==========

[srawlins, 2016-04-27 20:40:12]

Committed patchset #2 (id:20001) manually as
2cfa9c4665d1565bb762671c628d7ee2edf5fccc (presubmit successful).