pkg/analyzer/lib/src/task/dart.dart - Issue 1922563003: @deprecated should work on 'called' objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1922563003: @deprecated should work on 'called' objects (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Addressing feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/task/dart.dart

diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart

index 283bca3c0b1f6f72739b7d6e3e5e9efc04206229..84af156bca831bfd333000f7da47a641b096052b 100644

--- a/pkg/analyzer/lib/src/task/dart.dart

+++ b/pkg/analyzer/lib/src/task/dart.dart

@@ -2805,8 +2805,8 @@ class GenerateHintsTask extends SourceBasedAnalysisTask {

new InheritanceManager(libraryElement);

TypeProvider typeProvider = getRequiredInput(TYPE_PROVIDER_INPUT);

- unit.accept(new BestPracticesVerifier(errorReporter, typeProvider,

- typeSystem: typeSystem));

+ unit.accept(new BestPracticesVerifier(

+ errorReporter, typeProvider, libraryElement, typeSystem: typeSystem));

unit.accept(new OverrideVerifier(errorReporter, inheritanceManager));

// Find to-do comments.

new ToDoFinder(errorReporter).findIn(unit);