@deprecated should work on 'called' objects

pkg/analyzer/lib/src/generated/resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.resolver;
 
 import 'dart:collection';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
@@ skipping 59 matching lines @@
    * to have a bare "return;" in an async method.
    */
   final InterfaceType _futureNullType;
 
   /**
    * The type system primitives
    */
   TypeSystem _typeSystem;
 
   /**
+   * The current library
+   */
+  LibraryElement _currentLibrary;
+
+  /**
    * Create a new instance of the [BestPracticesVerifier].
    *
    * @param errorReporter the error reporter
    */
-  BestPracticesVerifier(this._errorReporter, TypeProvider typeProvider,
+  BestPracticesVerifier(
+      this._errorReporter, TypeProvider typeProvider, this._currentLibrary,
       {TypeSystem typeSystem})
       : _futureNullType = typeProvider.futureNullType,
         _typeSystem = (typeSystem != null) ? typeSystem : new TypeSystemImpl();
 
   @override
   Object visitArgumentList(ArgumentList node) {
     _checkForArgumentTypesNotAssignableInList(node);
     return super.visitArgumentList(node);
   }
 
@@ skipping 137 matching lines @@
       return super.visitMethodDeclaration(node);
     } finally {
       inDeprecatedMember = wasInDeprecatedMember;
     }
   }
 
   @override
   Object visitMethodInvocation(MethodInvocation node) {
     _checkForCanBeNullAfterNullAware(node.realTarget, node.operator);
     _checkForInvalidProtectedMethodCalls(node);
+    DartType staticInvokeType = node.staticInvokeType;
+    if (staticInvokeType is InterfaceType) {
+      MethodElement methodElement = staticInvokeType.lookUpMethod(
+              FunctionElement.CALL_METHOD_NAME, _currentLibrary);

[scheglov, 2016/04/26 15:54:19]

I'm concerned that we perform method lookup multiple times.
We must do this somewhere else already (and e.g. report that the variable is not
a function).

[srawlins, 2016/04/26 18:55:59]

Maybe... element_resolver.dart is where INVOCATION_OF_NON_FUNCTION is generated.
_isExecutableType is where we do this lookupMethod() already.

Are you suggesting that I move this check out of BestPracticesVerifier? I'm all
for simplifying this, so that BestPracticesVerifier doesn't need this
_currentLibrary, but I don't see how.

[scheglov, 2016/04/27 16:12:19]

  Yes, that's where I thought we could put the check.
  But maybe it does not worth it.

[srawlins, 2016/04/27 19:53:49]

Acknowledged.

+      _checkForDeprecatedMemberUse(methodElement, node);
+    }
     return super.visitMethodInvocation(node);
   }
 
   @override
   Object visitPostfixExpression(PostfixExpression node) {
     _checkForDeprecatedMemberUse(node.bestElement, node);
     return super.visitPostfixExpression(node);
   }
 
   @override
@@ skipping 280 matching lines @@
       String displayName = element.displayName;
       if (element is ConstructorElement) {
         // TODO(jwren) We should modify ConstructorElement.getDisplayName(),
         // or have the logic centralized elsewhere, instead of doing this logic
         // here.
         ConstructorElement constructorElement = element;
         displayName = constructorElement.enclosingElement.displayName;
         if (!constructorElement.displayName.isEmpty) {
           displayName = "$displayName.${constructorElement.displayName}";
         }
+      } else if (element.displayName == FunctionElement.CALL_METHOD_NAME &&

[Brian Wilkerson, 2016/04/26 15:25:28]

"element.displayName" --> "displayName"

[srawlins, 2016/04/27 19:53:49]

Done.

+          node is MethodInvocation &&
+          node.staticInvokeType is InterfaceType) {
+        displayName = "${node.staticInvokeType.displayName}.${element.displayName}";
       }
       _errorReporter.reportErrorForNode(
           HintCode.DEPRECATED_MEMBER_USE, node, [displayName]);
     }
   }
 
   /**
    * For [SimpleIdentifier]s, only call [checkForDeprecatedMemberUse]
    * if the node is not in a declaration context.
    *
@@ skipping 3691 matching lines @@
     unit.accept(_usedImportedElementsVisitor);
     // dead code analysis
     unit.accept(
         new DeadCodeVerifier(errorReporter, typeSystem: _context.typeSystem));
     unit.accept(_usedLocalElementsVisitor);
     // dart2js analysis
     if (_enableDart2JSHints) {
       unit.accept(new Dart2JSVerifier(errorReporter));
     }
     // Dart best practices
-    unit.accept(new BestPracticesVerifier(errorReporter, _context.typeProvider,
+    unit.accept(new BestPracticesVerifier(
+        errorReporter, _context.typeProvider, _library,
         typeSystem: _context.typeSystem));
     unit.accept(new OverrideVerifier(errorReporter, _manager));
     // Find to-do comments
     new ToDoFinder(errorReporter).findIn(unit);
     // pub analysis
     // TODO(danrubel/jwren) Commented out until bugs in the pub verifier are
     // fixed
     //    unit.accept(new PubVerifier(context, errorReporter));
   }
 }
@@ skipping 6512 matching lines @@
       return null;
     }
     if (identical(node.staticElement, variable)) {
       if (node.inSetterContext()) {
         result = true;
       }
     }
     return null;
   }
 }