MD Settings; Lazy instantiate Clear Browsing Data dialog.

MD Settings; Lazy instantiate Clear Browsing Data dialog.

BUG=599245
Committed: https://crrev.com/1b9f313d3f951b3ed38ca76eb4acface40a064d5
Cr-Commit-Position: refs/heads/master@{#390221}

[dpapad, 2016-04-25 23:46:42]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dpapad, 2016-04-25 23:46:43]

Using a dom-if boolean to show/hide the dialog, and adding an
'iron-overlay-closed' listener to set the boolean back to false, is a pattern
that has been working pretty well for other lazily instantiated dialogs, see
https://code.google.com/p/chromium/codesearch#search/&q=%22dialog.addEventLis....

[michaelpg, 2016-04-26 00:10:27]

https://codereview.chromium.org/1921913002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.js (right):

https://codereview.chromium.org/1921913002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.js:73:
this.showClearBrowsingDataDialog_ = false;
instead of this async stuff, would it still work if you added the
"on-iron-overlay-closed" attribute to the dialog in the HTML, so the handler
would just be a normal function on the prototype?

[dpapad, 2016-04-26 00:27:00]

https://codereview.chromium.org/1921913002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.js (right):

https://codereview.chromium.org/1921913002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.js:73:
this.showClearBrowsingDataDialog_ = false;
On 2016/04/26 at 00:10:26, michaelpg wrote:
> instead of this async stuff, would it still work if you added the
"on-iron-overlay-closed" attribute to the dialog in the HTML, so the handler
would just be a normal function on the prototype?

Done. It also works and is less verbose, thanks for the suggestion.

[dpapad, 2016-04-26 21:13:47]

On 2016/04/26 at 00:27:00, dpapad wrote:
>
https://codereview.chromium.org/1921913002/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/settings/privacy_page/privacy_page.js (right):
> 
>
https://codereview.chromium.org/1921913002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/privacy_page/privacy_page.js:73:
this.showClearBrowsingDataDialog_ = false;
> On 2016/04/26 at 00:10:26, michaelpg wrote:
> > instead of this async stuff, would it still work if you added the
"on-iron-overlay-closed" attribute to the dialog in the HTML, so the handler
would just be a normal function on the prototype?
> 
> Done. It also works and is less verbose, thanks for the suggestion.

Friendly ping.

[dpapad, 2016-04-27 20:50:27]

On 2016/04/26 at 21:13:47, dpapad wrote:
> On 2016/04/26 at 00:27:00, dpapad wrote:
> >
https://codereview.chromium.org/1921913002/diff/20001/chrome/browser/resource...
> > File chrome/browser/resources/settings/privacy_page/privacy_page.js (right):
> > 
> >
https://codereview.chromium.org/1921913002/diff/20001/chrome/browser/resource...
> > chrome/browser/resources/settings/privacy_page/privacy_page.js:73:
this.showClearBrowsingDataDialog_ = false;
> > On 2016/04/26 at 00:10:26, michaelpg wrote:
> > > instead of this async stuff, would it still work if you added the
"on-iron-overlay-closed" attribute to the dialog in the HTML, so the handler
would just be a normal function on the prototype?
> > 
> > Done. It also works and is less verbose, thanks for the suggestion.
> 
> Friendly ping.

Friendly ping.

[michaelpg, 2016-04-27 21:18:58]

Sorry I missed your first ping; lgtm.

[dpapad, 2016-04-27 21:21:11]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-04-27 21:21:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921913002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921913002/40001

[commit-bot: I haz the power, 2016-04-27 22:42:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:14:06]

Patchset 3 (id:??) landed as
https://crrev.com/1b9f313d3f951b3ed38ca76eb4acface40a064d5
Cr-Commit-Position: refs/heads/master@{#390221}

[commit-bot: I haz the power, 2016-04-30 17:52:34]

Description was changed from

==========
MD Settings; Lazy instantiate Clear Browsing Data dialog.

BUG=599245
==========

to

==========
MD Settings; Lazy instantiate Clear Browsing Data dialog.

BUG=599245

Committed: https://crrev.com/1b9f313d3f951b3ed38ca76eb4acface40a064d5
Cr-Commit-Position: refs/heads/master@{#390221}
==========